Skip to content
This repository has been archived by the owner on Nov 9, 2023. It is now read-only.

Fix some type issues #66

Merged
merged 5 commits into from
Oct 26, 2020
Merged

Fix some type issues #66

merged 5 commits into from
Oct 26, 2020

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Sep 18, 2020 •
edited
Loading

This fixes some mistakes, errors, and poor practices in index.d.ts.

@rekmarks rekmarks requested a review from a team as a code owner September 18, 2020 22:35
danfinlay
danfinlay approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@danfinlay danfinlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an improvement to me. Seems unknown is a new TS 3.0 feature that was cool to learn about.

@danfinlay danfinlay merged commit f938de6 into master Oct 26, 2020
@danfinlay danfinlay deleted the type-fixup branch October 26, 2020 02:10
@rekmarks rekmarks mentioned this pull request Oct 26, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danfinlay danfinlay danfinlay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rekmarks @danfinlay