This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
Add eip 1559 support 2 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 8, 2021
darkwing
reviewed
Nov 9, 2021
index.js
Outdated
| @@ -30,6 +52,16 @@ class TrezorKeyring extends EventEmitter { | |||
| this.paths = {}; | |||
| this.deserialize(opts); | |||
| TrezorConnect.manifest(TREZOR_CONNECT_MANIFEST); | |||
| TrezorConnect.getFeatures().then((features) => { | |||
There was a problem hiding this comment.
I think having this call right here is going to be problematic. I'm seeing the Trezor connection window pop up way too frequently and when performing actions that don't relate to Trezor. I'll need to research the best place to put this.
aloisklink
reviewed
Nov 9, 2021
This adds support for EIP-1559 for the Trezor T, once we get all this library to work with it as well. We use version "8.2.1-extended" exactly, as we need non-browser support for local tests.
Although 3.3.0 is out, I've selected ^3.2.1 just to match the current version of MetaMask's package.json file. Version 3.2.0 adds support for EIP-1559 transactions.
Test case copied over from MetaMask/eth-ledger-bridge-keyring#99
This adds support for object-rest-spread (e.g. {...x, ...y}),
without using the babel parser, which we use in tests.
This is different from what the Metamask extension has, which
is 2017, but they're using the babel parser.
Creating an unfrozen transaction (added in #88) seems to be a change that was only required in eth-ledger-keyring, not in Trezor, and is fixed by @ethereumjs/tx: v3.1.4 anyway. I've removed this part, since it was causing issues with EIP-1559 transactions, and does not seem necessary for non-EIP-1559 transactions either.
Co-authored-by: Alois Klink <[email protected]>
danjm
force-pushed
the
add-eip-1559-support-2
branch
from
07479ab to
8ad61f4
Compare
darkwing
reviewed
Nov 17, 2021
index.js
Outdated
| this.model = event.payload.features.model; | ||
| } | ||
| }); | ||
| TrezorConnect.init({ manifest: TREZOR_CONNECT_MANIFEST }) |
There was a problem hiding this comment.
@danjm Brilliant move with DEVICE_EVENT event listening! Unfortunately the event was never firing for me. What does work, however, is this change I've made, which puts the event listener first and then triggers the event via init.
darkwing
approved these changes
Nov 18, 2021
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on the work by @aloisklink in #97
This expands on that PR by adding a method for determining the model of the device, allowing us to detect whether the current model supports EIP-1559