feat: replace @metamask/ethjs-{contract,query} packages with @ethersproject for EIP1193 compatibility
#155
Conversation
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is new author?A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package. Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights. What is a CVE?Contains a high severity Common Vulnerability and Exposure (CVE). Remove or replace dependencies that include known high severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies. What is network access?This module accesses the network. Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use. Why is native code a concern?Contains native code (e.g., compiled binaries or shared libraries). Including native code can obscure malicious behavior. Verify that the inclusion of native code is expected and necessary for this package's functionality. If it is unnecessary or unexpected, consider using alternative packages without native code to mitigate potential risks. What is an AI-detected potential code anomaly?AI has identified unusual behaviors that may pose a security risk. An AI system found a low-risk anomaly in this package. It may still be fine to use, but you should check that it is safe before proceeding. What is a shrinkwrap file?Package contains a shrinkwrap file. This may allow the package to bypass normal install procedures. Packages should never use npm shrinkwrap files due to the dangers they pose. What is a mild CVE?Contains a low severity Common Vulnerability and Exposure (CVE). Remove or replace dependencies that include known low severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
cryptodev-2s
changed the title
ethjs* packages with @ethersprojectethjs* packages with @ethersproject for EIP1193 compatibility
cryptodev-2s
changed the title
ethjs* packages with @ethersproject for EIP1193 compatibilityethjs* packages with ethers for EIP1193 compatibility
cryptodev-2s
changed the title
ethjs* packages with ethers for EIP1193 compatibility@metamask/ethjs* packages with ethers for EIP1193 compatibility
cryptodev-2s
changed the title
@metamask/ethjs* packages with ethers for EIP1193 compatibility@metamask/ethjs-{contract,query} packages with ethers for EIP1193 compatibility
This reverts commit 6d0229b.
cryptodev-2s
changed the title
@metamask/ethjs-{contract,query} packages with ethers for EIP1193 compatibility@metamask/ethjs-{contract,query} packages with @ethersproject for EIP1193 compatibility
cryptodev-2s
deleted the
cryptodev2s/replace-eths-package-with-ethersproject
branch
This PR replaces
@metamask/ethjs-contractand@metamask/ethjs-query, which lack EIP-1193 compatibility, with their respective alternatives from@ethersproject.Fixes: #156