Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ci by updating node 22x version to 22.5.1 #146

Closed
wants to merge 1 commit into from

Conversation

kanthesha
Copy link
Contributor

There seems to be a regression in Node 22.5.0 which yarnpkg/berry#6398 and in turns prevents CI from completing successfully. This regression was nodejs/node#53935. We are using 22.x in CI, so in theory it should be using this version, but that does not seem be the case right now. So this commit ensures that CI is using this version by naming it explicitly in engines.node of package.json.

@kanthesha kanthesha marked this pull request as ready for review July 22, 2024 10:36
@kanthesha kanthesha requested a review from a team as a code owner July 22, 2024 10:36
@cryptodev-2s
Copy link

cryptodev-2s commented Jul 22, 2024

@kanthesha we should update github workflow here https://github.com/MetaMask/eth-token-tracker/blob/main/.github/workflows/build-lint-test.yml (all node-version) we don't need to update package.json ? what do you think ?

@kanthesha
Copy link
Contributor Author

kanthesha commented Jul 22, 2024

The solution has been tested in the forked repo and it works fine. Here is the link.
https://github.com/kanthesha/eth-token-tracker/actions/runs/10039757976/job/27744374737?pr=3

@kanthesha
Copy link
Contributor Author

kanthesha commented Jul 22, 2024

Seems like we don't need a fix now.
The versions manifest of github actions didn't had the 22.5.1 and it use to pull 22.5.0. And now it's been updated in this PR and merged an hour ago. Should work without we explicitly specifying the exact version.

@kanthesha kanthesha closed this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants