This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
refactor: sync all accounts on snap notificaiton #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danroc
force-pushed
the
feature/dont-fail-sync
branch
4 times, most recently
from
8ae393a to
30f7992
Compare
danroc
force-pushed
the
feature/dont-fail-sync
branch
from
97ba479 to
5b872e6
Compare
danroc
force-pushed
the
feature/dont-fail-sync
branch
from
96dce97 to
4ff1b8c
Compare
danroc
changed the title
danroc
changed the title
montelaidev
approved these changes
Jun 28, 2023
danroc
added a commit
that referenced
this pull request
Sep 7, 2023
* chore: don't fail account sync * fix: fix `update`, `create`, and `delete` account methods * feat: schedule accounts sync after keyring creation or deserialization * fix: let the snap call back to remove the account from maps * feat: sync accounts after deserialization * fix: don't sync on deserialization since snaps don't seem to be ready * chore: make `getAccounts()` async * chore: make `syncAccounts()` public * refactor: sync all accounts on snap update * fix: always use lower case addresses in the maps * fix: normalize addresses on deserialization * test: update unit tests * chore: update unit test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.