Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

feat(272): add chainId to Keyring API requests (transaction/typed message) #231

Merged
merged 5 commits into from
Mar 5, 2024
Merged

feat(272): add chainId to Keyring API requests (transaction/typed message) #231

merged 5 commits into from
Mar 5, 2024

Commits on Mar 5, 2024

  1. feat: add toCaipChainId helper + tests

    @ccharly
    ccharly committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    29a7702 View commit details
    Browse the repository at this point in the history

  2. feat: compute caip-2 chain ID when submitting requests

    @ccharly
    ccharly committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    f90d6c0 View commit details
    Browse the repository at this point in the history

  3. test: verify signTransaction call parameters 

    For some reason, the encoding of `type` and `data` are different from
what we have.

I didn't track down this behavior, so it could be a small "mistake" on
our side, or there is different encoding being used somewhere in the
flow.
    @ccharly
    ccharly committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    f649ff8 View commit details
    Browse the repository at this point in the history

  4. test: verify scope during sign{Transaction,TypedMessage} calls

    @ccharly
    ccharly committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    fb591b0 View commit details
    Browse the repository at this point in the history

  5. test: add test over scope with non-defined chainId

    @ccharly
    ccharly committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    b09a4ea View commit details
    Browse the repository at this point in the history