Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

fix: reject unsupported account methods #190

Merged
merged 5 commits into from
Dec 18, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed .idea folder
k-g-j committed Dec 15, 2023
commit 2f75e1a09d8c6d5eb94f12debf111833e8667e55
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -67,6 +67,9 @@ node_modules/
# Stores VSCode versions used for testing VSCode extensions
.vscode-test

# IntelliJ
.idea

# yarn v3 (w/o zero-install)
# See: https://yarnpkg.com/getting-started/qa#which-files-should-be-gitignored
.pnp.*
8 changes: 0 additions & 8 deletions .idea/.gitignore

This file was deleted.

13 changes: 0 additions & 13 deletions .idea/checkstyle-idea.xml

This file was deleted.

218 changes: 0 additions & 218 deletions .idea/codeStyles/Project.xml

This file was deleted.

5 changes: 0 additions & 5 deletions .idea/codeStyles/codeStyleConfig.xml

This file was deleted.

7 changes: 0 additions & 7 deletions .idea/discord.xml

This file was deleted.

9 changes: 0 additions & 9 deletions .idea/eth-snap-keyring.iml

This file was deleted.

6 changes: 0 additions & 6 deletions .idea/inspectionProfiles/Project_Default.xml

This file was deleted.

141 changes: 0 additions & 141 deletions .idea/intellij-javadocs-4.0.1.xml

This file was deleted.

6 changes: 0 additions & 6 deletions .idea/jpa-buddy.xml

This file was deleted.

6 changes: 0 additions & 6 deletions .idea/jsLinters/eslint.xml

This file was deleted.

9 changes: 0 additions & 9 deletions .idea/misc.xml

This file was deleted.

8 changes: 0 additions & 8 deletions .idea/modules.xml

This file was deleted.

7 changes: 0 additions & 7 deletions .idea/prettier.xml

This file was deleted.

6 changes: 0 additions & 6 deletions .idea/vcs.xml

This file was deleted.

13 changes: 12 additions & 1 deletion src/SnapKeyring.test.ts
Original file line number Diff line number Diff line change
@@ -224,14 +224,25 @@ describe('SnapKeyring', () => {
).toBeNull();
});

it('fails when the method is not supported', async () => {
it('fails when the method is invalid', async () => {
await expect(
keyring.handleKeyringSnapMessage(snapId, {
method: 'invalid',
}),
).rejects.toThrow('Method not supported: invalid');
});

it('fails when the method is not supported', async () => {
// TODO: mock account with unsupported sign method
await expect(
keyring.handleKeyringSnapMessage(snapId, {
method: 'eth_sendTransaction',
}),
).rejects.toThrow(
"Method 'eth_sendTransaction' not supported for account 0xC728514Df8A7F9271f4B7a4dd2Aa6d2D723d3eE3",
);
});

it('approves an async request', async () => {
mockSnapController.handleRequest.mockResolvedValue({
pending: true,