Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid duplicate errors #105

Merged
merged 2 commits into from
Sep 8, 2021
Merged

Avoid duplicate errors #105

merged 2 commits into from
Sep 8, 2021

Conversation

tmashuang
Copy link
Contributor

@tmashuang tmashuang requested a review from a team as a code owner September 8, 2021 16:36
@tmashuang tmashuang mentioned this pull request Sep 8, 2021
Merged
Gudahtt
Gudahtt requested changes Sep 8, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! There is one more example of this on line 406 though

@tmashuang tmashuang requested a review from Gudahtt September 8, 2021 16:50
Gudahtt
Gudahtt approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tmashuang tmashuang merged commit 42bc3ba into main Sep 8, 2021
@tmashuang tmashuang deleted the avoid-duplicate-error branch September 8, 2021 16:52
julianariel pushed a commit to block-wallet/eth-ledger-bridge-keyring that referenced this pull request Apr 27, 2022
@tmashuang
Avoid duplicate errors (MetaMask#105)
fe695c8 
* Avoid duplicate errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmashuang @Gudahtt