Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config to exclude node-fetch in browser builds #78

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Add config to exclude node-fetch in browser builds #78

merged 1 commit into from
Mar 23, 2021

Conversation

rekmarks
Copy link
Member

Fixes #71

@rekmarks rekmarks requested a review from a team as a code owner March 23, 2021 21:05
@rekmarks rekmarks requested a review from NiranjanaBinoy March 23, 2021 21:05
NiranjanaBinoy
NiranjanaBinoy approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@NiranjanaBinoy NiranjanaBinoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rekmarks rekmarks merged commit a40713e into main Mar 23, 2021
@rekmarks rekmarks deleted the browser-no-node-fetch branch March 23, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiranjanaBinoy NiranjanaBinoy NiranjanaBinoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove node-fetch from production dependencies
2 participants
@rekmarks @NiranjanaBinoy