Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace 'url' dependency with native URL global #67

Merged
merged 2 commits into from
Dec 15, 2020
Merged

Replace 'url' dependency with native URL global #67

merged 2 commits into from
Dec 15, 2020

Conversation

NiranjanaBinoy
Copy link
Contributor

We should just use the native URL global whenever we deal with URLs.
closes #64

@NiranjanaBinoy NiranjanaBinoy self-assigned this Dec 15, 2020
@NiranjanaBinoy NiranjanaBinoy marked this pull request as ready for review December 15, 2020 21:08
@NiranjanaBinoy NiranjanaBinoy requested a review from a team as a code owner December 15, 2020 21:08
rekmarks
rekmarks approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@NiranjanaBinoy NiranjanaBinoy merged commit 84fd68f into master Dec 15, 2020
@NiranjanaBinoy NiranjanaBinoy deleted the replace-url-dependencies branch December 15, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rekmarks rekmarks rekmarks approved these changes

Assignees

@NiranjanaBinoy NiranjanaBinoy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace 'url' dependency with native URL global
2 participants
@NiranjanaBinoy @rekmarks