Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes in typed signature validation and normalization #318

Merged
merged 8 commits into from
Jul 23, 2024
Merged

Changes in typed signature validation and normalization #318

merged 8 commits into from
Jul 23, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jul 18, 2024

@jpuri jpuri requested a review from a team as a code owner July 18, 2024 15:42
jpuri
jpuri commented Jul 18, 2024
View reviewed changes
src/utils/normalize.ts
return address;
function normalizeContractAddress(address: Hex): Hex {
if (address.startsWith('0X')) {
return `0x${address.slice(2)}`;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normilizing decimal and octal value is removed now, only normalization now is replacing 0X prefix with 0x.

mcmire
mcmire previously approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmire
Copy link
Contributor

mcmire commented Jul 18, 2024

Oof, I see that CI is failing. This could be either a problem where the cache is not being properly restored, or the incorrect set of files is being saved in the cache. In other repos we've discussed replacing yarn --immutable --immutable-cache with yarn --immutable in .github/workflows/build-lint-test.yml. I'll try to investigate soon, but you could experimenting with that if you're stuck.

@legobeat
Copy link
Contributor

Oof, I see that CI is failing. This could be either a problem where the cache is not being properly restored, or the incorrect set of files is being saved in the cache. In other repos we've discussed replacing yarn --immutable --immutable-cache with yarn --immutable in .github/workflows/build-lint-test.yml. I'll try to investigate soon, but you could experimenting with that if you're stuck.

Saw this in other repos when rerunning previously passing jobs. Also specifically Node 22.

Node.js 22.5.0 was just released so maybe something lurking here?

Unless it's simply an intermittent infra issue at GH.

@cryptodev-2s
Copy link
Contributor

Oof, I see that CI is failing. This could be either a problem where the cache is not being properly restored, or the incorrect set of files is being saved in the cache. In other repos we've discussed replacing yarn --immutable --immutable-cache with yarn --immutable in .github/workflows/build-lint-test.yml. I'll try to investigate soon, but you could experimenting with that if you're stuck.

Saw this in other repos when rerunning previously passing jobs. Also specifically Node 22.

Node.js 22.5.0 was just released so maybe something lurking here?

Unless it's simply an intermittent infra issue at GH.

Oof, I see that CI is failing. This could be either a problem where the cache is not being properly restored, or the incorrect set of files is being saved in the cache. In other repos we've discussed replacing yarn --immutable --immutable-cache with yarn --immutable in .github/workflows/build-lint-test.yml. I'll try to investigate soon, but you could experimenting with that if you're stuck.

Saw this in other repos when rerunning previously passing jobs. Also specifically Node 22.

Node.js 22.5.0 was just released so maybe something lurking here?

Unless it's simply an intermittent infra issue at GH.

@legobeat a fix for this has just been included in a new node patch v22.5.1

@mcmire
Copy link
Contributor

mcmire commented Jul 19, 2024

I've fixed the Node issue here: #321

matthewwalsh0
matthewwalsh0 previously approved these changes Jul 20, 2024
View reviewed changes
@jpuri jpuri requested a review from mcmire July 22, 2024 08:27
OGPoyraz
OGPoyraz previously approved these changes Jul 22, 2024
View reviewed changes
mcmire
mcmire previously approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

cryptodev-2s
cryptodev-2s requested changes Jul 23, 2024
View reviewed changes
.github/workflows/build-lint-test.yml Outdated
@@ -32,7 +32,7 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
cache: 'yarn'
- run: yarn --immutable --immutable-cache
Copy link
Contributor

@cryptodev-2s cryptodev-2s Jul 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can maybe rollback this change ? It's not required for the ci if you update your branch the ci will work again

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I updated the PR

@jpuri jpuri dismissed stale reviews from mcmire, OGPoyraz, and matthewwalsh0 via f0536b1 July 23, 2024 23:24
@jpuri jpuri requested a review from cryptodev-2s July 23, 2024 23:24
cryptodev-2s
cryptodev-2s approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jpuri jpuri requested a review from mcmire July 23, 2024 23:26
@jpuri jpuri merged commit a055a59 into main Jul 23, 2024
19 checks passed
@jpuri jpuri deleted the sign_validations branch July 23, 2024 23:26
MajorLift added a commit that referenced this pull request Aug 14, 2024
@MajorLift
Add changelog entries for #318
061bde0
MajorLift added a commit that referenced this pull request Aug 14, 2024
@MajorLift
Add changelog entries for #318
d4cf300
@MajorLift MajorLift mentioned this pull request Aug 14, 2024
Merged
MajorLift added a commit that referenced this pull request Aug 20, 2024
@MajorLift
Add changelog entries for #318 (#327)
17d1ac9
@digiwand digiwand mentioned this pull request Sep 9, 2024
Closed
Gudahtt added a commit that referenced this pull request Oct 2, 2024
@Gudahtt
Merge remote-tracking branch 'origin/main' into sync-v14-main
568232d 
* origin/main:
  fix: change types signatures verifyingContract validation to allow 'cosmos' as address (#334)
  Update `main` with changes from v14.0.1 (#332)
  Request validation should not throw if verifyingContract is not defined in typed signature (#328)
  Add changelog entries for `#318` (#327)
  remove eth_sign (#320)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptodev-2s cryptodev-2s cryptodev-2s approved these changes

@matthewwalsh0 matthewwalsh0 matthewwalsh0 left review comments

@OGPoyraz OGPoyraz OGPoyraz left review comments

@mcmire mcmire Awaiting requested review from mcmire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jpuri @mcmire @legobeat @cryptodev-2s @OGPoyraz @matthewwalsh0