Remove providerFromEngine and providerFromMiddleware
#194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
remove-provider-from-functions
branch
2 times, most recently
from
5fefc9f
to
2729334
Compare
Gudahtt
commented
Feb 11, 2023
| // forward any error | ||
| if (err) { | ||
| return end(err); | ||
| // TODO: Remove this cast when next major `json-rpc-engine` release is out | ||
| // The next release changes how errors are propogated. |
There was a problem hiding this comment.
For some reason, json-rpc-engine was demanding that this be Error or null. Yet it's immediately serialized, and serializeError accepts unknown.
Seems fine to cast it for now because it ought to be accepting unknown, unless I'm missing something.
I see that on the main branch of that repo, end no longer accepts an error at all, so we'll have to update how this works with the next major release anyway.
Gudahtt
force-pushed
the
remove-provider-from-functions
branch
2 times, most recently
from
92a0637
to
eb1ba6c
Compare
The two provider construction functions have been removed. These functions are instead availabile from the new package `eth-json-rpc-provider`.
Gudahtt
force-pushed
the
remove-provider-from-functions
branch
from
eb1ba6c
to
1032edf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two provider construction functions have been removed. These functions are instead availabile from the new package
eth-json-rpc-provider.