chore: replace json-stable-stringify with safe-stable-stringify #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BridgeAR
changed the title
BridgeAR
force-pushed
the
switch-to-safe-stable-stringify
branch
from
d7a037a
to
87cedb9
Compare
|
Thank you for your contribution! This needs to be rebased, but in any event, I don't believe that we want to accept circular references in any way. Would you be willing to add that as a feature to |
BridgeAR
force-pushed
the
switch-to-safe-stable-stringify
branch
from
87cedb9
to
12cd897
Compare
|
@rekmarks thanks for the feedback. I went ahead and implemented such option and updated the PR accordingly. |
|
Hey @BridgeAR , sorry for the delay! I can review this again once the conflicts are resolved |
BridgeAR
force-pushed
the
switch-to-safe-stable-stringify
branch
from
12cd897
to
023b289
Compare
|
@Gudahtt thanks, I just rebased the PR. |
This is a performance improvement as the latter is actually faster. json-stable-stringify x 13,870 ops/sec ±0.72% (94 runs sampled) safe-stable-stringify x 30,367 ops/sec ±0.39% (96 runs sampled)
BridgeAR
force-pushed
the
switch-to-safe-stable-stringify
branch
from
023b289
to
77dac8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a performance improvement as the latter is actually faster.
json-stable-stringify x 13,870 ops/sec ±0.72% (94 runs sampled)
safe-stable-stringify x 30,367 ops/sec ±0.39% (96 runs sampled)
The only difference is that objects with circular reference are from
now on also accepted instead of throwing an error.