Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove babel #10

Merged
merged 2 commits into from
Dec 13, 2020
Merged

Remove babel #10

merged 2 commits into from
Dec 13, 2020

Conversation

radotzki
Copy link
Contributor

@radotzki radotzki commented Apr 4, 2019

I suggest removing Babel because:

  1. Babel is not needed in this package
  2. It causing the build of web3-provider-engine to fail

radotzki and others added 2 commits April 4, 2019 15:27
@radotzki
Remove babel
8acc43d 
I suggest removing Babel because:
1. Babel is not needed in this package
2. It causing [web3-provider-engine](https://github.com/MetaMask/web3-provider-engine) to faile building
@rekmarks
Merge branch 'master' into patch-1
0e54874
@rekmarks rekmarks requested a review from a team as a code owner December 13, 2020 19:38
rekmarks
rekmarks approved these changes Dec 13, 2020
View reviewed changes
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our apologies for the delay.

@rekmarks rekmarks merged commit 0206e09 into MetaMask:master Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rekmarks rekmarks rekmarks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radotzki @rekmarks