Add util for creating extendable ESLint configurations #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
force-pushed
the
mrtenz/config-utils
branch
from
4c8a1b8 to
0e669be
Compare
Mrtenz
force-pushed
the
mrtenz/config-utils
branch
from
9518969 to
cb046f6
Compare
This reverts commit cb046f6.
Mrtenz
commented
Sep 26, 2024
| // TODO: Use import attributes when ESLint supports them. | ||
| const customRequire = createRequire(import.meta.url); | ||
| const environmentRules = customRequire('./environment.json'); | ||
|
|
||
| /** | ||
| * @type {import('eslint').Linter.Config[]} | ||
| */ | ||
| const rules = [ |
There was a problem hiding this comment.
GitHub shows this as a lot of changes, but essentially it just wraps the entire config in createConfig. As you can tell by the rules snapshot, the actual config hasn't changed.
cryptodev-2s
previously approved these changes
Sep 26, 2024
cryptodev-2s
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typescript-eslinthas a nice util function to create a config with anextendsproperty, similar to the legacy ESLint configuration format. We don't use TypeScript in all projects however, and the function has some limitations. In this PR, I've created a similar functioncreateConfig, which is exported from@metamask/eslint-config.The function supports an
extendsproperty, which accepts:{ extends: configObjectA }.{ extends: [configObjectA, configObjectB] }.{ extends: [[configObjectA, configObjectB]] }.