Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to omit packages #98

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Conversation

cryptodev-2s
Copy link
Contributor

This PR allows users to omit packages from the release spec that have changes since their previous release to make it possible to make partial releases.

Issue: 92

@legobeat
Copy link
Contributor

@cryptodev-2s Alternative that might resolve some motivation behind this change: #99

@Gudahtt
Copy link
Member

Gudahtt commented Sep 13, 2023

@legobeat Thanks, good idea, I have approved your other PR. But I still think we need something like this PR to make the process for omitting packages easier.

Originally we had intentionally added friction to dissuade people from omitting packages because omitting packages can be hazardous in ways that are easy to miss. But #90 and #91 should make the process a lot safer. After those are resolved, we want to make partial releases a low-friction process. Typing intentionally-skip 12 times isn't quite low friction enough to make this a pleasant tool to use.

I would suggest putting this on hold until after #90 and #91 are resolved, then merging this or something like it. We can consider alternative approaches to this PR as well, so long as they also achieve the goal of making partial releases low-friction.

@mcmire
Copy link
Contributor

mcmire commented Oct 2, 2023

Given Mark's comment, does it make sense to mark this ticket as being blocked in some way?

@cryptodev-2s
Copy link
Contributor Author

Given Mark's comment, does it make sense to mark this ticket as being blocked in some way?

it's currently marked as blocked by 90 and 91 which there's two PRs waiting for review

@mcmire
Copy link
Contributor

mcmire commented Oct 5, 2023

Okay, I've marked it as such using Zenhub.

@cryptodev-2s cryptodev-2s force-pushed the allow-users-to-omit-packages branch from 0efabdc to 4665b32 Compare October 24, 2023 13:11
@cryptodev-2s
Copy link
Contributor Author

@legobeat PR updated now intentionally-skip is mandatory only when a package is used by another package or uses a package not on the release spec

Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@cryptodev-2s cryptodev-2s merged commit c41cc8b into main Oct 25, 2023
19 checks passed
@cryptodev-2s cryptodev-2s deleted the allow-users-to-omit-packages branch October 25, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants