-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to omit packages #98
Conversation
@cryptodev-2s Alternative that might resolve some motivation behind this change: #99 |
@legobeat Thanks, good idea, I have approved your other PR. But I still think we need something like this PR to make the process for omitting packages easier. Originally we had intentionally added friction to dissuade people from omitting packages because omitting packages can be hazardous in ways that are easy to miss. But #90 and #91 should make the process a lot safer. After those are resolved, we want to make partial releases a low-friction process. Typing I would suggest putting this on hold until after #90 and #91 are resolved, then merging this or something like it. We can consider alternative approaches to this PR as well, so long as they also achieve the goal of making partial releases low-friction. |
Given Mark's comment, does it make sense to mark this ticket as being blocked in some way? |
it's currently marked as blocked by 90 and 91 which there's two PRs waiting for review |
Okay, I've marked it as such using Zenhub. |
0efabdc
to
4665b32
Compare
@legobeat PR updated now intentionally-skip is mandatory only when a package is used by another package or uses a package not on the release spec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
This PR allows users to omit packages from the release spec that have changes since their previous release to make it possible to make partial releases.
Issue: 92