Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] feat: allow npm:name@version dependency redirections in manifest (#158) #159

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 29, 2024

@legobeat legobeat changed the title feat: allow npm:name@version dependency redirections in manifest (#158) [3.x] feat: allow npm:name@version dependency redirections in manifest (#158) Oct 29, 2024
@legobeat legobeat marked this pull request as ready for review October 29, 2024 00:02
@legobeat legobeat requested a review from a team as a code owner October 29, 2024 00:02
Copy link

socket-security bot commented Oct 29, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/[email protected] None 0 4.45 kB types
npm/[email protected] unsafe 0 7.77 kB npm-cli-ops

View full report↗︎

@legobeat legobeat force-pushed the v3-allow-resolution-aliases branch from 256d7e3 to 9ae71f4 Compare October 29, 2024 00:05
Copy link

socket-security bot commented Oct 29, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@legobeat
Copy link
Contributor Author

@SocketSecurity ignore npm/[email protected]

new author ok

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat merged commit 898f072 into MetaMask:v3.x Oct 29, 2024
16 checks passed
Gudahtt added a commit that referenced this pull request Nov 1, 2024
* [3.x] feat: allow `npm:name@version` dependency redirections in manifest (#158) (#159)

feat: allow `npm:name@version` dependency redirections in manifest (#158)

* 3.1.0 (#160)

* 3.1.0

* chore: update changelog

---------

Co-authored-by: github-actions <[email protected]>
Co-authored-by: legobt <[email protected]>

---------

Co-authored-by: legobeat <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <[email protected]>
Co-authored-by: legobt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants