Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Increment root package version based on release specification #103

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Sep 29, 2023

Before this change, the new version of the root package is always incremented by one (or minor one, for backports). This results in all releases being "major" releases, even though the packages incremented in the release could be minor or patch increments. With this change, the root package version is now determined by the most significant subpackage increment. For example, if all packages versions are patch increments, the root package version will be incremented with a patch increment, etc.

Breaking changes

  • This removes the backport option, as it's no longer used for anything.

@mcmire
Copy link
Contributor

mcmire commented Dec 4, 2023

@Mrtenz Hmm. We've been creating backports for various libraries lately, so although that hasn't happened for core yet, I hesitate to remove that feature from this tool.

A little context: When we revised the release process for the core monorepo, we decided that the release version wouldn't abide by SemVer (I don't have the discussion handy, but I can find it). Why? Because the monorepo isn't a public package. The only place that the monorepo release version shows up is release notes, but no one needs to use it explicitly. It's just a way of naming the release. We discussed using a date instead of a version string as a name, but then if we wanted to name a backport release, we wouldn't have a good way of doing that. Repurposing the version string seemed to satisfy our need at the time.

I understand if this might be confusing, though. I'm open to other alternatives, as long as there's still some way to denote a backport. What are your thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants