Update Package Reader to Accept Range Versions in Dependencies (#106)

MetaMask · Nov 8, 2023 · 203b612 · 203b612
1 parent c41cc8b
commit 203b612
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/package-manifest.test.ts b/src/package-manifest.test.ts
@@ -64,6 +64,8 @@ describe('package-manifest', () => {
           private: true,
           dependencies: {
             a: '1.0.0',
+            b: '^2.0.0',
+            c: '~4.3.0',
           },
         };
         const validated = {
@@ -73,6 +75,8 @@ describe('package-manifest', () => {
           private: true,
           dependencies: {
             a: '1.0.0',
+            b: '^2.0.0',
+            c: '~4.3.0',
           },
           peerDependencies: {},
         };
@@ -94,6 +98,8 @@ describe('package-manifest', () => {
           private: true,
           peerDependencies: {
             a: '1.0.0',
+            b: '^2.0.0',
+            c: '~4.3.0',
           },
         };
         const validated = {
@@ -104,6 +110,8 @@ describe('package-manifest', () => {
           dependencies: {},
           peerDependencies: {
             a: '1.0.0',
+            b: '^2.0.0',
+            c: '~4.3.0',
           },
         };
         await fs.promises.writeFile(manifestPath, JSON.stringify(unvalidated));

diff --git a/src/package-manifest.ts b/src/package-manifest.ts
@@ -6,7 +6,7 @@ import {
 import { isPlainObject } from '@metamask/utils';
 import { readJsonObjectFile } from './fs';
 import { isTruthyString } from './misc-utils';
-import { isValidSemver, SemVer } from './semver';
+import { semver, SemVer } from './semver';
 
 export { PackageManifestFieldNames, PackageManifestDependenciesFieldNames };
 
@@ -139,7 +139,7 @@ export function readPackageManifestNameField(
 function isValidPackageManifestVersionField(
   version: unknown,
 ): version is string {
-  return isTruthyString(version) && isValidSemver(version);
+  return isTruthyString(version) && semver.validRange(version) !== null;
 }
 
 /**