Refactor NetworkController to BaseControllerV2 #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BelfordZ
force-pushed
the
refactor-network-controller-v2
branch
3 times, most recently
from
a1c0977 to
5fd5125
Compare
BelfordZ
commented
Sep 8, 2022
BelfordZ
force-pushed
the
refactor-network-controller-v2
branch
2 times, most recently
from
9dae659 to
3e332e4
Compare
BelfordZ
force-pushed
the
refactor-network-controller-v2
branch
from
815b372 to
c4144f9
Compare
BelfordZ
changed the title
BelfordZ
force-pushed
the
refactor-network-controller-v2
branch
from
c4144f9 to
3e44e92
Compare
BelfordZ
commented
Sep 22, 2022
BelfordZ
commented
Sep 22, 2022
BelfordZ
force-pushed
the
refactor-network-controller-v2
branch
5 times, most recently
from
7d7ccc8 to
4c820f9
Compare
mcmire
reviewed
Sep 26, 2022
BelfordZ
force-pushed
the
refactor-network-controller-v2
branch
from
e9c3f68 to
1dd3dbd
Compare
BelfordZ
force-pushed
the
refactor-network-controller-v2
branch
from
1dd3dbd to
1e6e2a1
Compare
Gudahtt
reviewed
Sep 29, 2022
Gudahtt
reviewed
Sep 29, 2022
Fixed tests to pass Added test isolation of race condition Remove node-version file Fixed TokenListController test Fixed broken tests Fix network controller to no longer use settimeout Fixed test cleanup in a variety of cases Remove tsfmt file Update collectibles controller tests to minimize refactoring Change infura api keys to fake ones in tests where possible
BelfordZ
force-pushed
the
refactor-network-controller-v2
branch
from
f47b678 to
bdc7690
Compare
|
Looked through again and this looks good pending the changes mentioned above. |
mcmire
approved these changes
Oct 3, 2022
Gudahtt
added a commit
that referenced
this pull request
Nov 8, 2022
This fixes a deadlock accidentally introduced as part of #903. That PR introduced an early exit in the `net_version` callback that did not release the lock. A `try...finally` block has been introduced to ensures the lock is always released.
Gudahtt
added a commit
that referenced
this pull request
Nov 8, 2022
This fixes a deadlock accidentally introduced as part of #903. That PR introduced an early exit in the `net_version` callback that did not release the lock. A `try...finally` block has been introduced to ensures the lock is always released.
Gudahtt
added a commit
that referenced
this pull request
Nov 8, 2022
This fixes a deadlock accidentally introduced as part of #903. That PR introduced an early exit in the `net_version` callback that did not release the lock. A `try...finally` block has been introduced to ensures the lock is always released.
gantunesr
pushed a commit
that referenced
this pull request
Dec 8, 2022
* Refactor NetworkController to BaseControllerV2 Change onNetworkStateChange to use messaging system & use providerChange event where possible. Co-authored-by: Shane Jonas <[email protected]>
gantunesr
pushed a commit
that referenced
this pull request
Dec 8, 2022
This fixes a deadlock accidentally introduced as part of #903. That PR introduced an early exit in the `net_version` callback that did not release the lock. A `try...finally` block has been introduced to ensures the lock is always released.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Refactor NetworkController to BaseControllerV2 Change onNetworkStateChange to use messaging system & use providerChange event where possible. Co-authored-by: Shane Jonas <[email protected]>
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
This fixes a deadlock accidentally introduced as part of #903. That PR introduced an early exit in the `net_version` callback that did not release the lock. A `try...finally` block has been introduced to ensures the lock is always released.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Refactor NetworkController to BaseControllerV2 Change onNetworkStateChange to use messaging system & use providerChange event where possible. Co-authored-by: Shane Jonas <[email protected]>
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
This fixes a deadlock accidentally introduced as part of #903. That PR introduced an early exit in the `net_version` callback that did not release the lock. A `try...finally` block has been introduced to ensures the lock is always released.
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NetworkController update to extend from BaseControllerV2
swaps out the base controller, implements messenger, fixes all the tests associated
Description
BREAKING:
ControllerMessengerCHANGED:
Checklist
Issue
#902