Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unused events from UserStorageController #5324

Merged
merged 3 commits into from
Feb 13, 2025
Merged

fix: remove unused events from UserStorageController #5324

merged 3 commits into from
Feb 13, 2025

Conversation

mathieuartu
Copy link
Contributor

@mathieuartu mathieuartu commented Feb 13, 2025 •
edited
Loading

Explanation

This PR removes unused event types from UserStorageController

References

Changelog

@metamask/profile-sync-controller

  • REMOVED: removed unused events from UserStorageController

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@mathieuartu mathieuartu changed the title fix: remove unused events fix: remove unused events from UserStorageController Feb 13, 2025
@mathieuartu mathieuartu self-assigned this Feb 13, 2025
@mathieuartu mathieuartu added the team-identity Identity Team changes. https://github.com/orgs/MetaMask/teams/identity label Feb 13, 2025
@mathieuartu mathieuartu marked this pull request as ready for review February 13, 2025 13:52
@mathieuartu mathieuartu requested review from a team as code owners February 13, 2025 13:52
Prithpal-Sooriya
Prithpal-Sooriya approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

You may need to update the description to flag this as breaking.

@mathieuartu
Copy link
Contributor Author

LGTM

You may need to update the description to flag this as breaking.

It's fine no worries, these events only existed as types and never were implemented in the end

@mathieuartu mathieuartu enabled auto-merge (squash) February 13, 2025 14:45
@mathieuartu mathieuartu merged commit 13ca538 into main Feb 13, 2025
130 checks passed
@mathieuartu mathieuartu deleted the fix/clean-user-storage-controller branch February 13, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

Assignees

@mathieuartu mathieuartu

Labels
team-identity Identity Team changes. https://github.com/orgs/MetaMask/teams/identity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathieuartu @Prithpal-Sooriya