Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change maxNumberOfAccountsToAdd default value from 100 to Infinity #5322

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

mathieuartu
Copy link
Contributor

Explanation

This PR changes the default value for account syncing's maxNumberOfAccountsToAdd from 100 to Infinity.
It will become the client's responsibility to set this number to a specific value. If not specified, account sync will synchronize every account.

References

Related to: https://consensyssoftware.atlassian.net/browse/IDENTITY-28

Changelog

@metamask/profile-sync-controller

  • CHANGED: change maxNumberOfAccountsToAdd default value from 100 to Infinity

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@mathieuartu mathieuartu added the team-identity Identity Team changes. https://github.com/orgs/MetaMask/teams/identity label Feb 13, 2025
@mathieuartu mathieuartu self-assigned this Feb 13, 2025
@mathieuartu mathieuartu marked this pull request as ready for review February 13, 2025 10:49
@mathieuartu mathieuartu requested review from a team as code owners February 13, 2025 10:49
@mathieuartu mathieuartu merged commit a7718b8 into main Feb 13, 2025
135 checks passed
@mathieuartu mathieuartu deleted the fix/remove-account-number-limit-sync branch February 13, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-identity Identity Team changes. https://github.com/orgs/MetaMask/teams/identity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants