fix: fix account controller legacy polling #5321
Merged
+38
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salimtb
force-pushed
the
fix/fix-account-tracker-legacy-polling
branch
from
afe784a to
111a39f
Compare
| @@ -35,8 +35,7 @@ | |||
| "no-shadow": 2 | |||
| }, | |||
| "packages/assets-controllers/src/AccountTrackerController.test.ts": { | |||
| "import-x/namespace": 2, | |||
| "import-x/order": 2 | |||
| "import-x/namespace": 2 | |||
Prithpal-Sooriya
approved these changes
Feb 13, 2025
sahar-fehri
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Changes were made to accountTrackerController inside the @metamask/assets-controllers package.
The account tracker polling was executed on the constructor with the initialisation. This caused additional requests to be sent by the app, leading to performance issues.
Additionally, the accountTracker was still using legacy polling via the poll function. This function has now been removed, and a test has been added to prevent the creation of multiple polling instances.
These changes improve efficiency by reducing unnecessary network requests and ensuring the polling mechanism is properly controlled.
References
Changelog
@metamask/assets-controllersChecklist