chore: Remove BaseControllerV1

[MajorLift]

Explanation

Removes the deprecated BaseControllerV1 and its associated types and methods, replacing them with the V2 BaseController, its derived classes, and helper methods.

This is the culmination of work completed over multiple quarters, and represents a major step forward for performative and best practice-compliant state management in our clients.

References

• Closes Remove BaseControllerV1 #5041
• Blocked by fix: Migrate AbstractMessageManager from BaseControllerV1 to BaseControllerV2 #5103

Changelog

@metamask/base-controller

Changed

• Widen input parameter for type guard isBaseController from ControllerInstance to unknown.

Removed

• BREAKING: Remove class BaseControllerV1 and type guard isBaseControllerV1.
• BREAKING: Remove types BaseConfig, BaseControllerV1Instance, BaseState, ConfigConstraintV1, Listener, StateConstraintV1, LegacyControllerStateConstraint, ControllerInstance.

@metamask/composable-controller

Changed

• BREAKING: Re-define ComposableControllerStateConstraint type using StateConstraint instead of LegacyControllerStateConstraint.
• BREAKING: Constrain the ComposableControllerState generic argument for the ComposableController class using ComposableControllerStateConstraint instead of LegacyComposableControllerStateConstraint.

@metamask/polling-controller

Removed

• BREAKING: Remove BlockTrackerPollingControllerV1, StaticIntervalPollingControllerV1.

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've highlighted breaking changes using the "BREAKING" category above as appropriate
• I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

[mcmire]

Woohoo! Looks great to me! (edit: oh, aside from the conflicts, boo. I will keep an eye on this PR then)

[cryptodev-2s]

LGTM! We want to merge this change along with the removal of Old Messenger Aliases, which is currently in draft: MetaMask/core#5260.

[mcmire]

Good call @cryptodev-2s, I'm going to mark this as DO-NOT-MERGE until that PR is ready to merge.

[mcmire]

LGTM!