-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 254.0.0 #4956
Merged
Merged
Release 254.0.0 #4956
Changes from 3 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
461964b
Initialize Release 254.0.0
ccharly eabc43e
Update Release 254.0.0
ccharly afbeb5b
chore: update changelogs
ccharly 47f1e8d
Update Release 254.0.0
ccharly 9b2827c
chore: update changelogs
ccharly c95d82f
fix: fix changelogs
ccharly 00683a5
chore: also release the assets-controllers
ccharly e1904af
chore: better changelog entry
ccharly 138e7fa
chore: remove snaps-controllers peer dependency bump entry
ccharly 16081bb
chore(chain-controller): 1.0.0 -> 0.2.0
ccharly 69aa8d6
chore: cosmetic
ccharly 796ccfc
Merge branch 'main' into release/254.0.0
ccharly 0df0b85
chore: better comments on changelog entries
ccharly 229a2fc
chore: remove duplicated entries
ccharly 7f0ffa6
chore: add missing changelog entry for assets-controllers
ccharly 627ec8a
chore: replace changelog entry for user-operation-controller
ccharly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |
|
||
## [Unreleased] | ||
|
||
## [19.0.1] | ||
|
||
### Changed | ||
|
||
- Bump `@metamask/keyring-api` from `^8.1.3` to `^10.1.0` ([#4948](https://github.com/MetaMask/core/pull/4948)) | ||
- Bump `@metamask/eth-snap-keyring` from `^4.3.6` to `^5.0.1` ([#4948](https://github.com/MetaMask/core/pull/4948)) | ||
- Bump `@metamask/snaps-utils` from `^4.3.6` to `^8.3.0` ([#4948](https://github.com/MetaMask/core/pull/4948)) | ||
- Bump `@metamask/snaps-sdk` from `^6.5.0` to `^6.7.0` ([#4948](https://github.com/MetaMask/core/pull/4948)) | ||
- Bump peer dependency `@metamask/snaps-controllers` from `^9.7.0`to `^9.10.0` ([#4948](https://github.com/MetaMask/core/pull/4948)) | ||
ccharly marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
## [19.0.0] | ||
|
||
### Changed | ||
|
@@ -343,7 +353,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |
|
||
- Initial release ([#1637](https://github.com/MetaMask/core/pull/1637)) | ||
|
||
[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/[email protected] | ||
[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/[email protected] | ||
[19.0.1]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
[19.0.0]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
[18.2.3]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
[18.2.2]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |
|
||
## [Unreleased] | ||
|
||
## [0.1.4] | ||
|
||
### Changed | ||
|
||
- Bump `@metamask/keyring-api` from `^8.1.3` to `^10.1.0` ([#4948](https://github.com/MetaMask/core/pull/4948)) | ||
ccharly marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- Bump `@metamask/snaps-utils` from `^4.3.6` to `^8.3.0` ([#4948](https://github.com/MetaMask/core/pull/4948)) | ||
- Bump `@metamask/snaps-sdk` from `^6.5.0` to `^6.7.0` ([#4948](https://github.com/MetaMask/core/pull/4948)) | ||
- Bump `@metamask/snaps-controllers` from `^9.7.0`to `^9.10.0` ([#4948](https://github.com/MetaMask/core/pull/4948)) | ||
- Bump `@metamask/utils` from `^9.1.0` to `^10.0.0` ([#4831](https://github.com/MetaMask/core/pull/4831)) | ||
|
||
## [0.1.3] | ||
|
||
### Changed | ||
|
@@ -57,7 +67,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |
|
||
- Initial release | ||
|
||
[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/[email protected] | ||
[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/[email protected] | ||
[0.1.4]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
[0.1.3]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
[0.1.2]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
[0.1.1]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |
|
||
## [Unreleased] | ||
|
||
## [18.0.1] | ||
|
||
### Changed | ||
|
||
- Bump `@metamask/keyring-api` from `^8.1.3` to `^10.1.0` ([#4948](https://github.com/MetaMask/core/pull/4948)) | ||
|
||
## [18.0.0] | ||
|
||
### Removed | ||
|
@@ -581,7 +587,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |
|
||
All changes listed after this point were applied to this package following the monorepo conversion. | ||
|
||
[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/[email protected] | ||
[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/[email protected] | ||
[18.0.1]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
[18.0.0]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
[17.3.1]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
[17.3.0]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@metamask/keyring-api
v10 ships with a@metamask/providers
(peer dependency) major version update that consumers of this package will have to update to, to avoid things breaking. I think this should be a major release forkeyring-controller
as well - what do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are right yes... I did some digging yesterday about this, and the versions seem ok using
yarn why
, see:@metamask/{keyring-api,eth-snap-keyring,snaps-*}
#4948 (comment)However, I still think we should have bump the direct dependencies to
snaps-*
in thekeyring-api
to "align" the minimum dependency on@metamask/providers
...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will re-release all packages and update the changelogs accordingly. I'm on it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Posted in another comment but is this right? TheSee other thread. We can resolve this conversation.@metamask/providers
peer dependency tells me that the thing that depends on@metamask/keyring-api
should also depend on@metamask/providers
, not the client. Or am I understanding this wrong?