Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 233.0.0 #4862

Merged
merged 6 commits into from
Oct 29, 2024
Merged

Release 233.0.0 #4862

merged 6 commits into from
Oct 29, 2024

Conversation

FrederikBolding
Copy link
Member

Explanation

Release PR to roll out newest version of @metamask/utils. This unblocks bumping the package elsewhere in the stack (e.g. for Snaps)

@FrederikBolding FrederikBolding requested review from a team as code owners October 29, 2024 09:22
@@ -52,7 +52,7 @@
"test:watch": "NODE_OPTIONS=--experimental-vm-modules jest --watch"
},
"dependencies": {
"@metamask/json-rpc-engine": "^10.0.0",
"@metamask/json-rpc-engine": "^10.0.1",
"@metamask/rpc-errors": "^7.0.1",
"@metamask/safe-event-emitter": "^3.0.0",
"@metamask/utils": "^10.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@metamask/eth-json-rpc-provider depends on @metamask/utils and is used in snaps (transitively by eth-block-tracker). Should it also be included in release?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matthewwalsh0
matthewwalsh0 previously approved these changes Oct 29, 2024
Copy link
Contributor

@legobeat legobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FrederikBolding FrederikBolding merged commit 557e28b into main Oct 29, 2024
119 checks passed
@FrederikBolding FrederikBolding deleted the release/233.0.0 branch October 29, 2024 11:25
Copy link

@dabossdana dabossdana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants