feat: ✨ update notification types and tests #4818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteoscurati
added
the
team-notifications
...ller/src/NotificationServicesController/types/on-chain-notification/on-chain-notification.ts
Show resolved
Hide resolved
...ervices-controller/src/NotificationServicesController/__fixtures__/mock-raw-notifications.ts
Show resolved
Hide resolved
Prithpal-Sooriya
approved these changes
Oct 18, 2024
matteoscurati
added a commit
that referenced
this pull request
Oct 22, 2024
## Explanation This is a RC for v224.0.0. See changelog for more details @metamask/notification-services-controller:0.10.1 ## References - https://consensyssoftware.atlassian.net/browse/NOTIFY-1230 - https://consensyssoftware.atlassian.net/browse/NOTIFY-1238 ## Changelog ``` ## [0.11.0] ### Added - Added support for an optional FCM token parameter for push notifications on mobile platforms, allowing native handling of FCM token creation through the Firebase SDK ([#4823](#4823)) ### Changed - update the types described in `types/on-chain-notification/schema` and `types/on-chain-notification/on-chain-notification` ([#4818](#4818)) - adds new notifications: aave_v3_health_factor; ens_expiration; lido_staking_rewards; notional_loan_expiration; rocketpool_staking_rewards; spark_fi_health_factor - splits Wallet Notifications from Web 3 Notifications - updated and added new notification mocks ([#4818](#4818)) - can be accessed through `@metamask/notification-services-controller/notification-services/mocks` ### Fixed - made `updateMetamaskNotificationsList` function work correctly by making the message handler async and moving the publish call outside of the update function. This ensures the `NotificationServicesController:notificationsListUpdated` event is received by the extension ([#4826](#4826)) ``` ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR introduces a better definition of the notification types described by the
NotificationServiceController. The new types allow for the description of the newWeb3Notificationwhile maintaining compatibility with the currentWalletNotification.References
Related to https://consensyssoftware.atlassian.net/browse/NOTIFY-1230?atlOrigin=eyJpIjoiMzYwOGEwNTFhN2IxNGRiMWEwZGU0N2IyNzI0MTExNzgiLCJwIjoiaiJ9
Changelog
@metamask/notification-services-controllertypes/on-chain-notification/schemaandtypes/on-chain-notification/on-chain-notificationmock-raw-notificationsChecklist