fix: 🐛 use better mock data #4791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prithpal-Sooriya
approved these changes
Oct 14, 2024
matteoscurati
added a commit
that referenced
this pull request
Oct 15, 2024
## Explanation This is a RC for v219.0.0. See changelog for more details - @metamask/notification-services-controller:0.10.0 ## References https://consensyssoftware.atlassian.net/browse/NOTIFY-1159 ## Changelog ``` ## [0.10.0] ### Changed - update `createMockNotification` functions to provide more realistic data for use in tests and component rendering in Storybook ([#4791](#4791)) ### Added - added the ability for the `fetchFeatureAnnouncementNotifications` function, within the `notification-services-controller`, to fetch draft content from Contentful. This is made possible by passing a `previewToken` parameter ([#4790](#4790)) ``` ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR modifies some mock data returned by the NotificationServicesController to provide more realistic data for use in tests and component rendering in Storybook.
References
N/A
Changelog
@metamask/notification-services-controllermock-raw-notificationsnow return more realistic mock dataChecklist