-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update subpath exports to use new .d.cts definition files. #4709
fix: update subpath exports to use new .d.cts definition files. #4709
Conversation
We have changes our ts bundler to ts-bridge, which exports new type definition files
We have changes our ts bundler to ts-bridge, which exports new type definition files
…le-sync-sdk-subpath-export
@metamaskbot publish-preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Sorry about this, I missed it in my PR.
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
OK tested this on extension, this is valid. Will merge :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Explanation
We have moved from tsup to ts-bridge, which generates a different path/file for typescript definition files.
This updates the notifications team packages that use subpath exports:
@metamask/profile-sync-controller
@metamask/notification-services-controller
References
https://consensyssoftware.atlassian.net/browse/NOTIFY-1108
Changelog
@metamask/profile-sync-controller
"types"
files."files"
in package.json@metamask/notification-services-controller
"types"
files.Checklist