Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update subpath exports to use new .d.cts definition files. #4709

Merged
merged 5 commits into from
Sep 17, 2024

Conversation

Prithpal-Sooriya
Copy link
Contributor

Explanation

We have moved from tsup to ts-bridge, which generates a different path/file for typescript definition files.

This updates the notifications team packages that use subpath exports:

  • @metamask/profile-sync-controller
  • @metamask/notification-services-controller

References

https://consensyssoftware.atlassian.net/browse/NOTIFY-1108

Changelog

@metamask/profile-sync-controller

  • CHANGED: Subpath exports "types" files.
  • ADDED: SDK to supported "files" in package.json

@metamask/notification-services-controller

  • CHANGED: Subpath exports "types" files.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

We have changes our ts bundler to ts-bridge, which exports new type definition files
We have changes our ts bundler to ts-bridge, which exports new type definition files
@Prithpal-Sooriya Prithpal-Sooriya added the team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications label Sep 16, 2024
@Prithpal-Sooriya Prithpal-Sooriya requested a review from a team as a code owner September 16, 2024 19:16
@Prithpal-Sooriya
Copy link
Contributor Author

@metamaskbot publish-preview

Copy link
Member

@Mrtenz Mrtenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Sorry about this, I missed it in my PR.

Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "18.2.1-preview-e34879fb",
  "@metamask-previews/address-book-controller": "6.0.1-preview-e34879fb",
  "@metamask-previews/announcement-controller": "7.0.1-preview-e34879fb",
  "@metamask-previews/approval-controller": "7.0.4-preview-e34879fb",
  "@metamask-previews/assets-controllers": "38.0.1-preview-e34879fb",
  "@metamask-previews/base-controller": "7.0.1-preview-e34879fb",
  "@metamask-previews/build-utils": "3.0.1-preview-e34879fb",
  "@metamask-previews/chain-controller": "0.1.2-preview-e34879fb",
  "@metamask-previews/composable-controller": "9.0.1-preview-e34879fb",
  "@metamask-previews/controller-utils": "11.3.0-preview-e34879fb",
  "@metamask-previews/ens-controller": "14.0.1-preview-e34879fb",
  "@metamask-previews/eth-json-rpc-provider": "4.1.4-preview-e34879fb",
  "@metamask-previews/gas-fee-controller": "20.0.1-preview-e34879fb",
  "@metamask-previews/json-rpc-engine": "9.0.3-preview-e34879fb",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.3-preview-e34879fb",
  "@metamask-previews/keyring-controller": "17.2.1-preview-e34879fb",
  "@metamask-previews/logging-controller": "6.0.1-preview-e34879fb",
  "@metamask-previews/message-manager": "10.1.1-preview-e34879fb",
  "@metamask-previews/name-controller": "8.0.1-preview-e34879fb",
  "@metamask-previews/network-controller": "21.0.1-preview-e34879fb",
  "@metamask-previews/notification-controller": "6.0.1-preview-e34879fb",
  "@metamask-previews/notification-services-controller": "0.5.1-preview-e34879fb",
  "@metamask-previews/permission-controller": "11.0.2-preview-e34879fb",
  "@metamask-previews/permission-log-controller": "3.0.1-preview-e34879fb",
  "@metamask-previews/phishing-controller": "12.0.3-preview-e34879fb",
  "@metamask-previews/polling-controller": "10.0.1-preview-e34879fb",
  "@metamask-previews/preferences-controller": "13.0.3-preview-e34879fb",
  "@metamask-previews/profile-sync-controller": "0.6.0-preview-e34879fb",
  "@metamask-previews/queued-request-controller": "5.0.1-preview-e34879fb",
  "@metamask-previews/rate-limit-controller": "6.0.1-preview-e34879fb",
  "@metamask-previews/selected-network-controller": "18.0.1-preview-e34879fb",
  "@metamask-previews/signature-controller": "19.1.0-preview-e34879fb",
  "@metamask-previews/transaction-controller": "37.0.0-preview-e34879fb",
  "@metamask-previews/user-operation-controller": "15.0.1-preview-e34879fb"
}

@Prithpal-Sooriya
Copy link
Contributor Author

OK tested this on extension, this is valid. Will merge :)

Copy link
Contributor

@matteoscurati matteoscurati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Prithpal-Sooriya Prithpal-Sooriya merged commit fbda88e into main Sep 17, 2024
116 checks passed
@Prithpal-Sooriya Prithpal-Sooriya deleted the notify/add-profile-sync-sdk-subpath-export branch September 17, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants