-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ✨ add support for different link types in feature announcements #4620
Merged
matteoscurati
merged 10 commits into
main
from
feat/notification-services-controller-feature-announcements-links
Sep 3, 2024
Merged
feat: ✨ add support for different link types in feature announcements #4620
matteoscurati
merged 10 commits into
main
from
feat/notification-services-controller-feature-announcements-links
Sep 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteoscurati
added
the
team-notifications
Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications
label
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Fix ESLint issues and also can you double check any // TODO comments related to mobile (just a quick search in this /notification-services-controller
folder
…ents-links' of github.com:MetaMask/core into feat/notification-services-controller-feature-announcements-links
…e-announcements-links
Prithpal-Sooriya
approved these changes
Aug 23, 2024
…e-announcements-links
…e-announcements-links
…e-announcements-links
…e-announcements-links
matteoscurati
deleted the
feat/notification-services-controller-feature-announcements-links
branch
September 3, 2024 10:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
team-notifications
Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR enhances the
notification-services-controller
package by adding support for various link types in feature announcements. The following changes have been made:TypeExternalLinkFields
,TypePortfolioLinkFields
, andTypeMobileLinkFields
to handle different types of links in feature announcements.FeatureAnnouncementRawNotificationData
: Included fields for external, portfolio, and mobile links.TypeFeatureAnnouncementFields
: Included fields for external, portfolio, and mobile links.fetchFeatureAnnouncementNotifications
: Updated the function to handle the new link types and include them in the notification data.These changes improve the flexibility and functionality of feature announcements by allowing them to include various types of links.
References
Changelog
@metamask/notification-services-controller
TypeExternalLinkFields
,TypePortfolioLinkFields
, andTypeMobileLinkFields
types to handle different types of links in feature announcements.FeatureAnnouncementRawNotificationData
to include fields for external, portfolio, and mobile links.TypeFeatureAnnouncementFields
to include fields for external, portfolio, and mobile links.fetchFeatureAnnouncementNotifications
to handle the new link types and include them in the notification data.Checklist