feat: add unlock checks for notification and profile sync controllers #4569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prithpal-Sooriya
force-pushed
the
NOTIFY-865-add-unlock-checks-for-notification-controllers
branch
from
f6a62e9 to
76832a8
Compare
Prithpal-Sooriya
added
the
team-notifications
mathieuartu
previously approved these changes
Jul 29, 2024
...ion-services-controller/src/NotificationServicesController/NotificationServicesController.ts
Outdated
Show resolved
Hide resolved
also changed requested name from review
…rs' of github.com:MetaMask/core into NOTIFY-865-add-unlock-checks-for-notification-controllers
mathieuartu
approved these changes
Jul 29, 2024
Prithpal-Sooriya
deleted the
NOTIFY-865-add-unlock-checks-for-notification-controllers
branch
AugmentedMode
pushed a commit
that referenced
this pull request
Jul 30, 2024
…#4569) ## Explanation This adds wallet unlock checks to ensure we only can call these controllers when the wallet is unlocked. This fixes potential issues in extension where we call these controllers when the wallet is locked (e.g. on browser startup) ## References [Ticket](https://consensyssoftware.atlassian.net/browse/NOTIFY-865) ## Changelog <!-- If you're making any consumer-facing changes, list those changes here as if you were updating a changelog, using the template below as a guide. (CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or FIXED. For security-related issues, follow the Security Advisory process.) Please take care to name the exact pieces of the API you've added or changed (e.g. types, interfaces, functions, or methods). If there are any breaking changes, make sure to offer a solution for consumers to follow once they upgrade to the changes. Finally, if you're only making changes to development scripts or tests, you may replace the template below with "None". --> ### `@metamask/profile-sync-controller` - **ADDED**: Actions and Events listening to the Keyring Controller unlock requests - **ADDED**: Unlock checks when the preinstalled snap is called. ### `@metamask/notification-services-controller` - **ADDED**: Actions and Events listening to the Keyring Controller unlock requests - **ADDED**: Unlock checks when trying to setup push notifications ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This adds wallet unlock checks to ensure we only can call these controllers when the wallet is unlocked. This fixes potential issues in extension where we call these controllers when the wallet is locked (e.g. on browser startup)
References
Ticket
Changelog
@metamask/profile-sync-controller@metamask/notification-services-controllerChecklist