Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueuedRequestController: Fix list of methods that should have requests enqueued and/or switch the globally selected network #4066

Merged
merged 17 commits into from
Apr 8, 2024
Merged

QueuedRequestController: Fix list of methods that should have requests enqueued and/or switch the globally selected network #4066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
0f08f89
wip
jiexi Mar 14, 2024
cedfd28
Merge branch 'main' into jl/fix-request-queue-switching-too-often
jiexi Mar 15, 2024
cd7d8d8
update method list
jiexi Mar 15, 2024
16a618f
lint
jiexi Mar 15, 2024
1e6355f
delete duplicate scenario
jiexi Mar 15, 2024
2eb0ff2
Add specs for new constants
jiexi Mar 15, 2024
908a3a6
add comments to constants
jiexi Mar 15, 2024
3705d8d
lint
jiexi Mar 15, 2024
7d6cb80
Merge branch 'main' into jl/fix-request-queue-switching-too-often
jiexi Mar 29, 2024
9decce6
fix conflict
jiexi Mar 29, 2024
d75b97c
Add methodsRequiringNetworkSwitch to QueuedRequestController
jiexi Mar 29, 2024
ad8dc07
fix QueuedRequestController specs. DRY builder
jiexi Mar 29, 2024
7043f74
Add methodsWithConfirmation param to QueuedRequestMiddleware
jiexi Mar 29, 2024
cf38935
fix QueuedRequestMiddleware specs. DRY builders
jiexi Mar 29, 2024
da8a670
remove constants
jiexi Mar 29, 2024
4215f65
update CHANGELOG
jiexi Mar 29, 2024
0f8e411
Merge branch 'main' into jl/fix-request-queue-switching-too-often
jiexi Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/queued-request-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Added

- **BREAKING**: The `QueuedRequestMiddleware` constructor now requires the `methodsWithConfirmation` param which should be a list of methods that can trigger confirmations ([#4066](https://github.com/MetaMask/core/pull/4066))
- **BREAKING**: The `QueuedRequestController` constructor now requires the `methodsRequiringNetworkSwitch` param which should be a list of methods that need the globally selected network to switched to the dapp selected network before being processed ([#4066](https://github.com/MetaMask/core/pull/4066))

### Changed

- **BREAKING**: `QueuedRequestController.enqueueRequest()` now ensures the globally selected network matches the dapp selected network before processing methods listed in the `methodsRequiringNetworkSwitch` constructor param. This replaces the previous behavior of switching for all methods except `eth_requestAccounts`. ([#4066](https://github.com/MetaMask/core/pull/4066))

## [0.7.0]

### Changed
Expand Down
Loading
Loading