fix: Preview build doc corrections #4053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The preview build documentation wrongly implied that the steps for using a local or preview build were different for MetaMask team members versus independent contributors. The steps are exactly the same. Additionally, the examples that use npm have been removed. The override syntax listed was not correct (npm doesn't use the same syntax for the version specifier), and the other instructions all reference Yarn anyway so the document already doesn't make much sense for a reader only familiar with npm.
Gudahtt
force-pushed
the
fix-preview-build-docs
branch
from
3e16de2
to
485c951
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The preview build documentation wrongly implied that the steps for using a local or preview build were different for MetaMask team members versus independent contributors. The steps are exactly the same.
Additionally, the examples that use npm have been removed. The override syntax listed was not correct (npm doesn't use the same syntax for the version specifier), and the other instructions all reference Yarn anyway so the document already doesn't make much sense for a reader only familiar with npm.
References
N/A
Changelog
None
Checklist