Migrate json rpc engine #1872

kanthesha · 2023-10-19T18:13:21Z

Explanation

We would like to migrate most MetaMask libraries into core monorepo to make them easier to maintain.

In this PR, we are migrating json-rpc-engine into core monorepo. In the process of migration, we don't want to remove / loose the original GIT history, but to preserve the history of the library as though the entire project had been located in a merged-packages/json-rpc-engine directory all along.

We chose to place json-rpc-engine initially in the merged-packages and not packages so we can hide it from Yarn, ESLint, Prettier, and TypeScript. This allows us to clean it up and conform it to how we've configured this repo before we properly incorporate it.

References

Closes Merge json-rpc-engine history into merged-packages #1881

Changelog

`@metamask/json-rpc-engine`

Migration: migrating json-rpc-engine to core monorepo

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've highlighted breaking changes using the "BREAKING" category above as appropriate

….0.0 (#162)

--------- Co-authored-by: github-actions <[email protected]> Co-authored-by: legobt <[email protected]> Co-authored-by: legobeat <[email protected]>

* applied eslint rules from core monorepo and fixed the errors * added eslint-import-resolver-typescript devDependencies

* 7.2.0 * release notes modified in changelog --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Kanthesha Devaramane <[email protected]>

socket-security · 2023-10-19T18:14:05Z

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
eslint-config-prettier	8.8.0	None	`+14`	6.04 MB	lydell
jest	29.7.0	None	`+105`	18 MB	simenb
rimraf	5.0.5	filesystem, environment	`+2`	1.43 MB	isaacs
prettier-plugin-packagejson	2.4.3	None	`+8`	11.4 MB	matzkoh
ts-jest	29.1.1	None	`+106`	18.3 MB	kul
@types/jest	29.5.6	eval	`+19`	4.91 MB	types
@typescript-eslint/eslint-plugin	5.58.0	None	`+24`	10.6 MB	jameshenry
@typescript-eslint/parser	5.58.0	None	`+19`	7.51 MB	jameshenry
@types/node	18.18.6	None	`+0`	3.8 MB	types
depcheck	1.4.3	None	`+28`	15.4 MB	rumpl
prettier	2.8.7	None	`+0`	11.2 MB	prettier-bot
eslint	8.38.0	None	`+13`	6.02 MB	eslintbot
eslint-plugin-import	2.27.5	None	`+37`	9.59 MB	ljharb
typedoc	0.24.1	None	`+2`	9.92 MB	typedoc-bot
eslint-plugin-jest	27.2.1	None	`+25`	10.9 MB	simenb

socket-security · 2023-10-19T18:14:12Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: [email protected], [email protected], @npmcli/[email protected], @npmcli/[email protected]

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

MajorLift

Looks good with clean history tree.

MajorLift · 2023-10-19T20:46:21Z

@SocketSecurity ignore-all

…rocess (#100) Duplicate of #92 with updated `main` branch ## **Description** This PR follows **[PR#6] 1. Migrate the source repo's git history into the merged-packages/ temporary directory in metamask design system** as part of the [package migration process guide](https://github.com/MetaMask/metamask-design-system/blob/main/docs/package-migration-process-guide.md#pr6-1-migrate-the-source-repos-git-history-into-the-merged-packages-temporary-directory-in-metamask-design-system). This step migrates the Git history of the `design-tokens` repository into the `metamask-design-system` monorepo, placing all contents under the `merged-packages/design-tokens` directory. [Example PR](MetaMask/core#1872) in core ## **Related issues** Partly fixes: #88 ## **Manual testing steps** 1. Check the contents under `merged-packages/design-tokens` in the `metamask-design-system` repository to ensure the file structure aligns with the original `design-tokens` repository. 2. Verify that the commit history within `merged-packages/design-tokens` accurately preserves previous `design-tokens` commits. 3. Confirm successful integration within the monorepo and that no errors are introduced. ## **Pre-merge author checklist** - [x] Verified `git-filter-repo` installation and migration process. - [x] Confirmed all `design-tokens` files are correctly moved to `merged-packages/design-tokens`. - [x] Checked that the full commit history for `design-tokens` is retained. - [x] Followed MetaMask Coding Standards. - [x] Set PR status appropriately. ## **Pre-merge reviewer checklist** - [ ] Confirmed that all `design-tokens` files appear in `merged-packages/design-tokens` with the correct structure. - [ ] Verified the commit history for `design-tokens` is intact and accurately reflects the original repository. - [ ] Ensured this PR meets all acceptance criteria.

kumavis added 30 commits September 16, 2016 15:41

rpc engine init commit

0ef398e

doc + fix returnHandlers

2740bd2

add response override

c32bc36

add nesting via asMiddleware

ac21066

latest changes

6091be4

test - add failing override test

4c8e2c2

remove override

7516779

1.0.0

304f6ef

meta - add repo info

d78cae6

refactor

c7f8e2c

2.0.0

4909d7f

asMiddleware - include in testing + more tests + copy res obj

e94b34a

2.1.0

93e2b72

asMiddleware - should not error even if end not called

8547b31

test - run tests in browser

7771299

2.2.0

286c271

move code into src

d10a609

meta - package.json add metadata

6cbc358

meta - add aegir

e74852c

lint fix

65a3729

lint

4028c5a

chore: update contributors

402f0c2

chore: release version v2.2.1

7be3712

chore: update contributors

fe1a389

chore: release version v2.2.2

d3f5230

chore: update contributors

1ce0da9

chore: release version v2.2.3

93b6ae3

meta - gitignore - dist

7b800cc

chore: update contributors

abb06e8

chore: release version v3.0.0

0ec3c60

dependabot bot and others added 13 commits August 28, 2023 22:51

Bump @metamask/utils from 5.0.2 to 7.0.0 (#158)

19021a2

Bump @metamask/auto-changelog from 3.1.0 to 3.2.0 (#157)

6007417

deps: @metamask/utils@^7.0.0->^8.1.0, @metamask/rpc-errors@^5.0.0->^6…

0f9394a

….0.0 (#162)

ci: run on node 20.x instead of 19.x (#167)

21bda95

7.1.1 (#166)

23aa8d9

--------- Co-authored-by: github-actions <[email protected]> Co-authored-by: legobt <[email protected]> Co-authored-by: legobeat <[email protected]>

Bump @metamask/auto-changelog from 3.2.0 to 3.3.0 (#168)

fc1ee03

bump eslint packages (#169)

05f12ef

Bump postcss from 8.4.21 to 8.4.31 (#170)

23efd23

Bump @metamask/rpc-errors from 6.0.0 to 6.1.0 (#171)

df6b121

applied eslint rules from core monorepo and fixed the errors (#172)

ee4a628

* applied eslint rules from core monorepo and fixed the errors * added eslint-import-resolver-typescript devDependencies

Bump @babel/traverse from 7.21.4 to 7.23.2 (#173)

ccdbf8e

7.2.0 (#174)

67c7fee

* 7.2.0 * release notes modified in changelog --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Kanthesha Devaramane <[email protected]>

Merge source repo 'json-rpc-engine/main' into migrate-json-rpc-engine

9e26409

kanthesha added the team-wallet-framework label Oct 19, 2023

kanthesha self-assigned this Oct 19, 2023

Merge branch 'main' into migrate-json-rpc-engine

2699d85

kanthesha marked this pull request as ready for review October 19, 2023 18:29

kanthesha requested a review from a team as a code owner October 19, 2023 18:29

MajorLift approved these changes Oct 19, 2023

View reviewed changes

Merge branch 'main' into migrate-json-rpc-engine

e767566

mcmire merged commit 59b1cdb into main Oct 19, 2023

mcmire deleted the migrate-json-rpc-engine branch October 19, 2023 20:48

kanthesha mentioned this pull request Oct 20, 2023

Migrate json rpc engine repo #1804

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate json rpc engine #1872

Migrate json rpc engine #1872

kanthesha commented Oct 19, 2023 •

edited by mcmire

Loading

socket-security bot commented Oct 19, 2023

socket-security bot commented Oct 19, 2023 •

edited

Loading

MajorLift left a comment

MajorLift commented Oct 19, 2023

Migrate json rpc engine #1872

Migrate json rpc engine #1872

Conversation

kanthesha commented Oct 19, 2023 • edited by mcmire Loading

Explanation

References

Changelog

@metamask/json-rpc-engine

Checklist

socket-security bot commented Oct 19, 2023

socket-security bot commented Oct 19, 2023 • edited Loading

Next steps

MajorLift left a comment

Choose a reason for hiding this comment

MajorLift commented Oct 19, 2023

kanthesha commented Oct 19, 2023 •

edited by mcmire

Loading

`@metamask/json-rpc-engine`

socket-security bot commented Oct 19, 2023 •

edited

Loading