Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump postcss from 8.4.20 to 8.4.31 in /merged-packages/eth-json-rpc-provider" #1790

Conversation

MajorLift
Copy link
Contributor

@MajorLift MajorLift commented Oct 5, 2023

Explanation

  • The contents of merged-packages/ shouldn't be altered, as it's a temporary directory used for migrating packages into the monorepo.
  • Any dependency updates for the migration target package need to be handled manually. The migration process involves aligning dependency versions with the monorepo (which may not use the latest version), removing dependencies that are defined in the monorepo root, and removing the yarn.lock file from the migration target subpackage.

Reference

@MajorLift MajorLift requested a review from a team as a code owner October 5, 2023 17:24
@MajorLift MajorLift self-assigned this Oct 5, 2023
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@MajorLift MajorLift merged commit ecf682b into main Oct 5, 2023
@MajorLift MajorLift deleted the revert-1775-dependabot/npm_and_yarn/merged-packages/eth-json-rpc-provider/postcss-8.4.31 branch October 5, 2023 18:30
MajorLift added a commit that referenced this pull request Oct 5, 2023
…rectories. (#1764)

## Explanation

This PR implements the following incremental step in the process for
migrating `eth-json-rpc-provider` into the core monorepo:

***

### Phase B: Staging in `migrated-packages/`
#### 1. Remove files and directories that will be replaced by
corresponding files in the monorepo root.
- [x] **Remove**: `.github/`, `.git*`, `scripts/`, `.depcheckrc.json`,
`.yarn/`, `.yarnrc.yml`, `yarn.lock`, `.editorconfig`, `.eslint*`,
`.prettier*`, `.nvm*`.
- [x] **Keep**: `src/`, `tests/`, `CHANGELOG.md`, `LICENSE`,
`package.json`, `README.md`, `jest.config.js`, `tsconfig*.json`,
`typedoc.json`.

***

See #1551 (comment)
for an outline of the entire process.

## Blocked by
- [x] #1790

## References

- Contributes to #1685
- Contributes to #1551

## Changelog

N/A

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
MajorLift added a commit that referenced this pull request Oct 11, 2023
…on-rpc-provider" (#1790)

## Explanation

- The contents of `merged-packages/` shouldn't be altered, as it's a
temporary directory used for migrating packages into the monorepo.
- Any dependency updates for the migration target package need to be
handled manually. The migration process involves aligning dependency
versions with the monorepo (which may not use the latest version),
removing dependencies that are defined in the monorepo root, and
removing the `yarn.lock` file from the migration target subpackage.

## Reference

- Blocks #1764
- See
#1079 (comment) for
context on the role of `merged-packages/`.
MajorLift added a commit that referenced this pull request Oct 11, 2023
…rectories. (#1764)

## Explanation

This PR implements the following incremental step in the process for
migrating `eth-json-rpc-provider` into the core monorepo:

***

### Phase B: Staging in `migrated-packages/`
#### 1. Remove files and directories that will be replaced by
corresponding files in the monorepo root.
- [x] **Remove**: `.github/`, `.git*`, `scripts/`, `.depcheckrc.json`,
`.yarn/`, `.yarnrc.yml`, `yarn.lock`, `.editorconfig`, `.eslint*`,
`.prettier*`, `.nvm*`.
- [x] **Keep**: `src/`, `tests/`, `CHANGELOG.md`, `LICENSE`,
`package.json`, `README.md`, `jest.config.js`, `tsconfig*.json`,
`typedoc.json`.

***

See #1551 (comment)
for an outline of the entire process.

## Blocked by
- [x] #1790

## References

- Contributes to #1685
- Contributes to #1551

## Changelog

N/A

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
MajorLift added a commit that referenced this pull request Oct 12, 2023
…on-rpc-provider" (#1790)

## Explanation

- The contents of `merged-packages/` shouldn't be altered, as it's a
temporary directory used for migrating packages into the monorepo.
- Any dependency updates for the migration target package need to be
handled manually. The migration process involves aligning dependency
versions with the monorepo (which may not use the latest version),
removing dependencies that are defined in the monorepo root, and
removing the `yarn.lock` file from the migration target subpackage.

## Reference

- Blocks #1764
- See
#1079 (comment) for
context on the role of `merged-packages/`.
MajorLift added a commit that referenced this pull request Oct 12, 2023
…rectories. (#1764)

## Explanation

This PR implements the following incremental step in the process for
migrating `eth-json-rpc-provider` into the core monorepo:

***

### Phase B: Staging in `migrated-packages/`
#### 1. Remove files and directories that will be replaced by
corresponding files in the monorepo root.
- [x] **Remove**: `.github/`, `.git*`, `scripts/`, `.depcheckrc.json`,
`.yarn/`, `.yarnrc.yml`, `yarn.lock`, `.editorconfig`, `.eslint*`,
`.prettier*`, `.nvm*`.
- [x] **Keep**: `src/`, `tests/`, `CHANGELOG.md`, `LICENSE`,
`package.json`, `README.md`, `jest.config.js`, `tsconfig*.json`,
`typedoc.json`.

***

See #1551 (comment)
for an outline of the entire process.

## Blocked by
- [x] #1790

## References

- Contributes to #1685
- Contributes to #1551

## Changelog

N/A

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants