Sync stale vault on keyring store update #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikesposito
force-pushed
the
fix/stale-vault
branch
from
ab236e0
to
e469d67
Compare
gantunesr
reviewed
May 23, 2023
mikesposito
changed the title
fullUpdate
gantunesr
previously approved these changes
May 23, 2023
mikesposito
force-pushed
the
fix/stale-vault
branch
from
a951c92
to
7970f4a
Compare
brad-decker
pushed a commit
to dragana8/core
that referenced
this pull request
Jun 1, 2023
* fix: update vault during fullUpdate * refactor: use event handler instead of fullUpdate * docs: rollback fullUpdate description
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* fix: update vault during fullUpdate * refactor: use event handler instead of fullUpdate * docs: rollback fullUpdate description
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* fix: update vault during fullUpdate * refactor: use event handler instead of fullUpdate * docs: rollback fullUpdate description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently,
KeyringControllerhas avaultin state that is never updated after its construction, which doesn't make sense and poses the risk of clients using this stale value.This "outer"
vaultshould be always in sync with the "inner"vaultmanaged by@metamask/eth-keyring-controller(this.#keyringinKeyringController).This PR adds an
EthKeyringControllerstore subscription in theKeyringControllerconstructor, syncing the vaults on each update.Changes
KeyringControllerandEthKeyingControllervaults are now kept in syncReferences
Checklist