Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-migration cleanup for @metamask/json-rpc-middleware-stream #1982

Closed
5 of 6 tasks
MajorLift opened this issue Nov 3, 2023 · 1 comment · Fixed by #2011 or #2014
Closed
5 of 6 tasks

Post-migration cleanup for @metamask/json-rpc-middleware-stream #1982

MajorLift opened this issue Nov 3, 2023 · 1 comment · Fixed by #2011 or #2014
Assignees
Labels

Comments

@MajorLift
Copy link
Contributor

MajorLift commented Nov 3, 2023

Tasks

References

@MajorLift MajorLift self-assigned this Nov 3, 2023
MajorLift added a commit that referenced this issue Nov 7, 2023
…middleware-stream}` (#1991)

## Explanation

- Updating root README dependency graph to reflect
`@metamask/json-rpc-engine` and `@metamask/json-rpc-middleware-stream`
migrations.

## References

- Partially implements #1981
- Partially implements #1982

## Changelog

N/A

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
@desi
Copy link
Contributor

desi commented Nov 8, 2023

@MajorLift Can you add an estimate to this one?

MajorLift added a commit that referenced this issue Nov 8, 2023
…stream}` migrations (#2003)

## Explanation

Records CHANGELOG entries from `@metamask/json-rpc-engine` and
`@metamask/json-rpc-middleware-stream` migrations under "Unreleased"
headers for reference during the next version release.

- [x] Records updates made to the `@metamask/json-rpc-engine` and
`@metamask/json-rpc-middleware-stream` packages since its last release,
and during the migration process.
- [x] Lists these migrations as ADDED changes.
- [x] Records version bumps of the migrated packages in downstream
repos.
- ~Records changes made to downstream repos.~

## References

- Partially implements #1981
- Partially implements #1982

## Changelog

N/A

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category
above as appropriate

---------

Co-authored-by: Elliot Winkler <[email protected]>
@MajorLift MajorLift mentioned this issue Nov 8, 2023
3 tasks
MajorLift added a commit that referenced this issue Nov 8, 2023
## Explanation

- Releases newly migrated packages:
  - `@metamask/eth-json-rpc-provider`
  - `@metamask/json-rpc-engine`
  - `@metamask/json-rpc-middleware-stream`

- Includes patch releases for version bumps in downstream packages.
- Treated migration as minor version change.

## References

- Partially implements #1842
- Closes #1981
- Closes #1982

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
@MajorLift MajorLift mentioned this issue Nov 8, 2023
3 tasks
MajorLift added a commit that referenced this issue Nov 8, 2023
## Explanation

- Releases newly migrated packages:
  - `@metamask/eth-json-rpc-provider`
  - `@metamask/json-rpc-engine`
  - `@metamask/json-rpc-middleware-stream`

- Includes patch releases for version bumps in downstream packages.
- Treated migration as minor version change.

## References

- Partially implements #1842
- Closes #1981
- Closes #1982

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants