-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post-migration cleanup for @metamask/json-rpc-middleware-stream
#1982
Labels
Comments
3 tasks
MajorLift
added a commit
that referenced
this issue
Nov 7, 2023
…middleware-stream}` (#1991) ## Explanation - Updating root README dependency graph to reflect `@metamask/json-rpc-engine` and `@metamask/json-rpc-middleware-stream` migrations. ## References - Partially implements #1981 - Partially implements #1982 ## Changelog N/A ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate
6 tasks
@MajorLift Can you add an estimate to this one? |
MajorLift
added a commit
that referenced
this issue
Nov 8, 2023
…stream}` migrations (#2003) ## Explanation Records CHANGELOG entries from `@metamask/json-rpc-engine` and `@metamask/json-rpc-middleware-stream` migrations under "Unreleased" headers for reference during the next version release. - [x] Records updates made to the `@metamask/json-rpc-engine` and `@metamask/json-rpc-middleware-stream` packages since its last release, and during the migration process. - [x] Lists these migrations as ADDED changes. - [x] Records version bumps of the migrated packages in downstream repos. - ~Records changes made to downstream repos.~ ## References - Partially implements #1981 - Partially implements #1982 ## Changelog N/A ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate --------- Co-authored-by: Elliot Winkler <[email protected]>
MajorLift
added a commit
that referenced
this issue
Nov 8, 2023
## Explanation - Releases newly migrated packages: - `@metamask/eth-json-rpc-provider` - `@metamask/json-rpc-engine` - `@metamask/json-rpc-middleware-stream` - Includes patch releases for version bumps in downstream packages. - Treated migration as minor version change. ## References - Partially implements #1842 - Closes #1981 - Closes #1982 ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate
MajorLift
added a commit
that referenced
this issue
Nov 8, 2023
## Explanation - Releases newly migrated packages: - `@metamask/eth-json-rpc-provider` - `@metamask/json-rpc-engine` - `@metamask/json-rpc-middleware-stream` - Includes patch releases for version bumps in downstream packages. - Treated migration as minor version change. ## References - Partially implements #1842 - Closes #1981 - Closes #1982 ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tasks
Update README to reflect new status as a non-root package in core monorepo.generate-dependency-graph
build script.@metamask/json-rpc-{engine,middleware-stream}
#1991Fix downstream errors that were marked with@ts-expect-error TODO:
during the migration process.@metamask/json-rpc-{engine,middleware-stream}
migrations #2003yarn create-release-branch
tool to publish a release of core with a new version for the migrated package and any updated downstream packages.Publish typedocs with GitHub Pages.References
The text was updated successfully, but these errors were encountered: