Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully migrate json-rpc-engine into core monorepo #1550

Closed
xinnanyemm opened this issue Jul 25, 2023 · 3 comments
Closed

Fully migrate json-rpc-engine into core monorepo #1550

xinnanyemm opened this issue Jul 25, 2023 · 3 comments
Assignees
@MajorLift @kanthesha
Labels
enhancement New feature or request Epic team-wallet-framework

Comments

@xinnanyemm
Copy link

xinnanyemm commented Jul 25, 2023 •
edited by mcmire
Loading

We would like to migrate the json-rpc-engine library into this repo to make it easier to maintain.

See the following checklist for instructions on accomplishing this: #1551 (comment)
@xinnanyemm
Copy link
Author

Hey team! Please add your planning poker estimate with Zenhub @cryptodev-2s @Gudahtt @kanthesha @MajorLift @mikesposito

@cryptodev-2s cryptodev-2s changed the title Migrate json-rpc-engine libraries into core monorepo Migrate json-rpc-engine library into core monorepo Sep 28, 2023
@Gudahtt
Copy link
Member

Gudahtt commented Oct 3, 2023

Note that json-rpc-engine has a number of PRs pending from rekmarks that we'd like to preserve, but not before merging the repo. We should migrate those branches/PRs into core so that they aren't lost

@kanthesha kanthesha mentioned this issue Oct 19, 2023
Merged
3 tasks
@mcmire mcmire reopened this Oct 20, 2023
@mcmire
Copy link
Contributor

mcmire commented Oct 20, 2023

Reopening since this isn't done yet!

@mcmire mcmire added the Epic label Oct 20, 2023
@mcmire mcmire mentioned this issue Oct 20, 2023
Closed
@mcmire mcmire changed the title Migrate json-rpc-engine library into core monorepo Fully migrate json-rpc-engine library into core monorepo Oct 20, 2023
@mcmire mcmire changed the title Fully migrate json-rpc-engine library into core monorepo Fully migrate json-rpc-engine into core monorepo Oct 20, 2023
@mcmire mcmire mentioned this issue Oct 20, 2023
Closed
3 tasks
@MajorLift MajorLift self-assigned this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MajorLift MajorLift

@kanthesha kanthesha

Labels
enhancement New feature or request Epic team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mcmire @Gudahtt @MajorLift @kanthesha @xinnanyemm