Fix omitted allowed{Actions,Events} not being inferred as never[]…

… when used with `unrestrictedMessenger` pattern - TODO: open ticket for more fundamental fix for this in `getRestricted` and `RestrictedControllerMessenger`
MetaMask · Mar 7, 2024 · 38d5e88 · 38d5e88
1 parent a4aea11
commit 38d5e88
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/packages/transaction-controller/jest.config.js b/packages/transaction-controller/jest.config.js
@@ -17,10 +17,10 @@ module.exports = merge(baseConfig, {
   // An object that configures minimum threshold enforcement for coverage results
   coverageThreshold: {
     global: {
-      branches: 94.06,
+      branches: 94.2,
       functions: 98.48,
-      lines: 98.87,
-      statements: 98.88,
+      lines: 98.91,
+      statements: 98.93,
     },
   },
 

diff --git a/packages/transaction-controller/src/TransactionControllerIntegration.test.ts b/packages/transaction-controller/src/TransactionControllerIntegration.test.ts
@@ -116,6 +116,8 @@ const setupController = async (
   const networkController = new NetworkController({
     messenger: unrestrictedMessenger.getRestricted({
       name: 'NetworkController',
+      allowedActions: [],
+      allowedEvents: [],
     }),
     trackMetaMetricsEvent: () => {
       // noop
@@ -131,6 +133,8 @@ const setupController = async (
   const approvalController = new ApprovalController({
     messenger: unrestrictedMessenger.getRestricted({
       name: 'ApprovalController',
+      allowedActions: [],
+      allowedEvents: [],
     }),
     showApprovalRequest: jest.fn(),
     typesExcludedFromRateLimiting: [ApprovalType.Transaction],