refactor(controller-utils): replace with in isNetworkType

MetaMask · Feb 26, 2024 · 181cd7e · 181cd7e
1 parent 0bd1e9d
commit 181cd7e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/controller-utils/src/types.test.ts b/packages/controller-utils/src/types.test.ts
@@ -2,7 +2,9 @@ import { isNetworkType, NetworkType } from './types';
 
 describe('types', () => {
   it('isNetworkType', () => {
+    // @ts-expect-error We are intentionally passing bad input.
     expect(isNetworkType({})).toBe(false);
+    // @ts-expect-error We are intentionally passing bad input.
     expect(isNetworkType(1)).toBe(false);
     expect(isNetworkType('test')).toBe(false);
     expect(isNetworkType('mainnet')).toBe(true);

diff --git a/packages/controller-utils/src/types.ts b/packages/controller-utils/src/types.ts
@@ -28,10 +28,8 @@ export type NetworkType = (typeof NetworkType)[keyof typeof NetworkType];
  * @param val - the value to check whether it is NetworkType or not.
  * @returns boolean indicating whether or not the argument is NetworkType.
  */
-// TODO: Replace `any` with type
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
-export function isNetworkType(val: any): val is NetworkType {
-  return Object.values(NetworkType).includes(val);
+export function isNetworkType(val: string): val is NetworkType {
+  return Object.values(NetworkType).includes(val as NetworkType);
 }
 
 /**