Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ACT-1472 - Add Improvements for JSON Schema #245

Merged
merged 1 commit into from
Jul 9, 2024
Merged

feat: ACT-1472 - Add Improvements for JSON Schema #245

merged 1 commit into from
Jul 9, 2024

Conversation

aednikanov
Copy link
Contributor

Add Improvements to JSON Schema required for the interactive params table in the Metamask Docs reference page.

@aednikanov aednikanov requested a review from a team as a code owner July 9, 2024 17:57
adonesky1
adonesky1 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shanejonas shanejonas merged commit 85d0b33 into main Jul 9, 2024
7 checks passed
@shanejonas shanejonas deleted the ACT-1452-fix-and-extend-schema branch July 9, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adonesky1 adonesky1 adonesky1 approved these changes

@shanejonas shanejonas shanejonas approved these changes

@joaniefromtheblock joaniefromtheblock Awaiting requested review from joaniefromtheblock

@alexandratran alexandratran Awaiting requested review from alexandratran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aednikanov @shanejonas @adonesky1