remove default channel #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
reviewed
May 9, 2024
Gudahtt
pushed a commit
that referenced
this pull request
May 10, 2024
Merged
Gudahtt
added a commit
that referenced
this pull request
May 10, 2024
* remove default channel (#73) * Release 4.0.3 --------- Co-authored-by: ricky <[email protected]>
Gudahtt
added a commit
that referenced
this pull request
May 10, 2024
* origin/main: remove default channel (#73) Don't fail overall if Slack announcement fails (#69) Improve Dry Run Output (#64) 5.0.0 (#67) Fix Yarn 4 compatibility (#65) Disallow publishing packages with version 0.0.0 (#63) Run linting and testing GitHub workflows on PRs (#62) Enabling MetaMask security code scanner (#60) Add Shared Libraries team in codeowners file (#59) Update README.md (#56) Update README.md (#55) Update README.md (#54) Bump word-wrap from 1.2.3 to 1.2.4 (#53)
Gudahtt
added a commit
that referenced
this pull request
May 10, 2024
* Don't fail overall if Slack announcement fails (#69) Typically, for a project, this action is run twice: once in dry-run mode (to allow approvers to review the package before it is published) and another time to issue the approval step and then actually publish the package. When the action is run in dry-run mode, an announcement on Slack is created in order to notify approvers. If this fails in any way, however, it halts the release workflow completely and prevents the second instance of the action from running. This means that the package can never be released automatically and must be released manually. This commit fix this problem by instructing GitHub Actions that it is not mandatory for the Slack announcement step to pass in order for the release workflow to continue. * Release 4.0.2 (#72) * remove default channel (#73) * Release 4.0.3 * fix: Fix action manifest validation error (#77) The action manifest used the id `slack` for two steps, which is not allowed. We don't reference this id anywhere, so it has been removed. * Release 4.0.4 (#78) --------- Co-authored-by: Elliot Winkler <[email protected]> Co-authored-by: ricky <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have found that the Slack announcement does not work correctly for public channels when the
channelparameter is given. The action has been updated to omit the default if no channel is specified, so that announcements tometamask-devwork correctly.