Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: auto configure from url param #724

Closed
wants to merge 1 commit into from
Closed

chore: auto configure from url param #724

wants to merge 1 commit into from

Conversation

0xffffharry
Copy link
Contributor

佛系提交。。。

允许通过URL Param直接配置远程，方便被第三方应用调用

例子：

http://127.0.0.1:4173/#/setup?url={url(URLEncoded)}

url示例：
http://127.0.0.1:9090/ （无secret）
http://[email protected]:9090/ （有secret）

@kunish
Copy link
Collaborator

kunish commented May 27, 2024

有几个疑问

  • 为什么不是放到 /setup 路由里处理而是在主页
  • 本地测试过没
  • chore 不会发版

@0xffffharry 0xffffharry mentioned this pull request May 28, 2024
Merged
@0xffffharry
Copy link
Contributor Author

抱歉，才发现原来代码中已有相关逻辑，但测试发现并无法正常运行，在 #726 中继续

@0xffffharry 0xffffharry deleted the add-auto-configure branch May 28, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xffffharry @kunish