Remove Int31 #983
Merged
Remove Int31 #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for Coq #17977 Modified files are - quotation/theories/ToPCUIC/Coq/Numbers.v - quotation/theories/ToTemplate/Coq/Numbers.v
|
Sorry to bother you with this @mattam82, but can we move forward? It would be nice to remove these files in 8.19. |
|
Is CI expected to go green on this? I just approved the run, if it goes green we can merge this for sure |
I have no idea what it means and how it can be related to this PR. |
JasonGross
reviewed
Sep 30, 2023
| @@ -1,9 +1,11 @@ | |||
| From Coq.Numbers Require Import BinNums DecimalFacts HexadecimalFacts | |||
| Cyclic.Int63.PrimInt63 Cyclic.Int31.Int31 | |||
| Cyclic.Int63.PrimInt63 Cyclic.Int63.Uint63 | |||
There was a problem hiding this comment.
Is this needed, or can we just do
Suggested change
| Cyclic.Int63.PrimInt63 Cyclic.Int63.Uint63 |
?
It means that somehow when building with is no longer valid and TransLookup_lookup_inductive'@{_ _} needs to be TransLookup_lookup_inductive'@{_ _ _} instead. It is unrelated to this PR. Maybe Coq broke something since the last CI run?
|
JasonGross
approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for Coq coq/coq#17977
Modified files are