add support for nix, like #705 but as branch in this repo #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can merge this as is, right? |
|
Yes, it should be good to go. I don't have the rights to rebase and update it though. |
|
I rebased it, if CI goes green this should be fine |
|
Thanks guys! |
Zimmi48
reviewed
Aug 5, 2022
| - reopened | ||
| push: | ||
| branches: | ||
| - master |
There was a problem hiding this comment.
FWIW, this value should probably be coq-8-14 so that the workflow runs when the branch is updated. But for now, the Coq Nix Toolbox generation mechanism always put master, so you'll probably have to fix this manually (and it could be worth opening an issue on the Coq Nix Toolbox repo about this).
| - reopened | ||
| push: | ||
| branches: | ||
| - master |
mattam82
pushed a commit
that referenced
this pull request
Sep 12, 2022
* add support for nix * hack around cachedMake script of coq-nix-toolbox * update coq-nix-toolbox version * testing with mac os CI Co-authored-by: Kenji Maillard <[email protected]>
mattam82
pushed a commit
that referenced
this pull request
Sep 13, 2022
* add support for nix * hack around cachedMake script of coq-nix-toolbox * update coq-nix-toolbox version * testing with mac os CI Co-authored-by: Kenji Maillard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.