-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparing for coq-metacoq.1.0~beta2+8.12
#540
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndP- Move syntactic equality checking to a separate safechecker library- move monadic combinators to monad_utils
…their right place
…ack fixing of universes, still needed in 8.11
Cleanup safechecker
The safe checker was destructing the inferred type of predicates directly as an arity, which was not complete. It meant that the following example was not accepted by the safe checker: Definition WrappedType := Type. Definition WrappedNat : WrappedType := nat. Definition foo : nat := match 0 return WrappedNat with | 0 => 0 | S n => 0 end. To fix we now use reduction for the predicate type.
Primitive integers and floats
…than anticipated: one really has to do surgeryon the binary applications derivation to produce onewhere applications are n-ary *without* relying on transitivity of cumulativityanywhere. This requires to use induction on the size of derivations (includingnon-principal/paranoid hypotheses).
Template <-> PCUIC proofs
In PCUIC we treated axioms as values, but we did not consistently treat eg. fixpoints and cases stuck on axioms as values. This removes the evaluation of axioms in PCUIC and gets rid of the axiom_free assumption that was needed for erasure because of it.
Remove evaluation of axioms from wcbv and add proof of consistency using safe reduction + canonicity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.