Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1283 disable new config #1343

Merged
merged 2 commits into from
Dec 13, 2024
Merged

fix #1283 disable new config #1343

merged 2 commits into from
Dec 13, 2024

Conversation

petersilva
Copy link
Contributor

@petersilva petersilva commented Dec 13, 2024

close #1283

In v2... "disable" use to be done by moving the config file to .off. this was changed to creating a state file.
but the variables still had "cfg" in them. so this fix is a little more involved.

  • determine the statedir (adding support for statehost which was missing.)
  • create the statedir if it is missing.
  • change all the variables to remove _cfg from the name... since not really appropriate anymore.

Copy link

github-actions bot commented Dec 13, 2024

Test Results

238 tests   235 ✅  1m 32s ⏱️
  1 suites    1 💤
  1 files      2 ❌

For more details on these failures, see this check.

Results for commit c90d74c.

♻️ This comment has been updated with latest results.

@petersilva petersilva marked this pull request as ready for review December 13, 2024 16:00
sarracenia/sr.py Outdated Show resolved Hide resolved
@petersilva petersilva merged commit c4a12ad into development Dec 13, 2024
0 of 5 checks passed
@petersilva petersilva deleted the issue1283 branch December 13, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sr3 disable doesn't work when a config is first created
2 participants