Refactor email plugin config syntax

[reidsunderland]

This is a proposal to change the email plugin configuration syntax to take advantage of the additional accept statement "arguments" added in #1289.

Previously, the email plugin had to do it's own regex matching/filtering to determine the recipients for a particular file. Now, it just gets the recipients from the mask, removing this redundancy.

I made a copy, called email_old before making modifications. I thought it might be useful if someone didn't want to update their config file.

Old syntax:

callback send.email_old

file_email_to AACN27 [email protected], [email protected]
file_email_relay email.relay.server.ca
file_email_from [email protected]

accept .*AACN27.*

New syntax:

callback send.email

sendTo smtp://email.relay.server.ca
# sendTo email.relay.server.ca  also works

# optional
email_from [email protected]

email_subject_prepend  Sent by Sarracenia: 

accept .*AACN27.*  [email protected], [email protected]

I also added a new option, email_subject_prepend, because we have some other email plugins internally that add extra text in the subject. I wanted this to be able to replace all of our email plugins, and eliminate hard-coded configuration in the plugin code.

[reidsunderland]

Oh, and it works in a sender or subscriber/sarra.

[petersilva]

This is a great improvement!

We tend to accumulate cruft (v1, 2, 3...) when we keep old stuff around... we have git for that. Would prefer to delete email_old, and have everyone change over... but could be done as second step for transition purposes... anyways not worth rejecting for that.

[github-actions]

Test Results

238 tests   235 ✅  1m 33s ⏱️
  1 suites    1 💤
  1 files      2 ❌

For more details on these failures, see this check.

Results for commit 18d9b9d.

[reidsunderland]

I looked at our configs and nothing is currently using the current/old email plugin, so I removed email_old. There's one config on dev and stage that we will update once we release the new sr3 version.