Issue1270 - fixing relative symlinks with (inappropriate) ../../ in them... #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
working on #1270. The relative path conversion is actually different for rename vs. link. the rename needs to take into account where in the tree it is, but the link is always from the destination directory (where the link is.) So the processing of 'link' and 'rename' is actually different. I need more testing, I think link is correct now.
Test Results238 tests 237 ✅ 1m 29s ⏱️ Results for commit 5b7179a. ♻️ This comment has been updated with latest results. |
petersilva
changed the title
reidsunderland
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1270
removed special relative translation that turns out to have been wrong-headed.
requires/works best with: MetPX/sarrac#168
with the two fixes, renames and symlinks should be a lot better.