Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweaks to flowcb/gather/file.py after experiments with noticing large files. #1258

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

petersilva
Copy link
Contributor

@petersilva petersilva commented Oct 10, 2024

some message naming things.

@reidsunderland to supplement. (edit to re-trigger tests)

Copy link

github-actions bot commented Oct 10, 2024

Test Results

249 tests   247 ✅  1m 32s ⏱️
  1 suites    1 💤
  1 files      1 ❌

For more details on these failures, see this check.

Results for commit f9b76dd.

♻️ This comment has been updated with latest results.

…ust in the likely impossible case that something goes wrong with lstat/st_mtime
@reidsunderland
Copy link
Member

I added my tweaks

@reidsunderland reidsunderland marked this pull request as ready for review October 11, 2024 13:09
Copy link
Member

@andreleblanc11 andreleblanc11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good.

@petersilva petersilva merged commit 1c7261d into development Oct 11, 2024
34 of 60 checks passed
@petersilva petersilva deleted the inflight_fileAgeMin branch October 11, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants